-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate: Strict mode #126
Conversation
Great job David 😁! I've added some comments. |
Thanks Jonathan! I just made a commit applying those comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @d4vsanchez, thanks for working on this, this PR is looking reaaally good, just left a couple of minor comments that I think we should address before merging.
If you think that my suggestions don't apply, just let me know, we can talk about it!
Thanks again for your contribution!
* `constructor` | ||
* `componentWillMount` | ||
* `componentWillReceiveProps` | ||
* `componentWillUpdate` | ||
* `getDerivedStateFromProps` | ||
* `shouldComponentUpdate` | ||
* `render` | ||
* `setState` updater functions (the first argument) | ||
* Funciones de actualización de `setState` (el primer argumento) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand this one, is it OK? haha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haha it sounds good I think 😂
Hey @alejandronanez, they were very valuable! I have made a new commit applying those suggestions and also modifying the "Advertencia" in the bullet points section.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I've done translating
Strict mode
to Spanish. #4I'm having some doubts with some stuff in the translation and I hope you can help me with them if you have a better way to translate it:
fase de confirmación
.string ref
,callback ref
,object ref
. I've basically left them as is; I can instead translate themreferencia de string
(to comply with the translation guideline table),referencia de objeto
andreferencia de callback
. What do you think it's better?cc: @alejandronanez @dmoralesm @carburo