Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translating Invalid hook call warning #141

Merged
merged 13 commits into from
Feb 12, 2019
Merged

Translating Invalid hook call warning #141

merged 13 commits into from
Feb 12, 2019

Conversation

jpvg10
Copy link
Contributor

@jpvg10 jpvg10 commented Feb 11, 2019

Related to #4.

Also related to #71 (custom hooks -> hooks personalizados), #77 (event handler -> manejador de eventos) and #81 (warning -> advertencia)

Also I have some doubts about some expressions I used here, so I would appreciate some feedback:
mismatching -> incongruente
peer dependency -> ?
workaround -> solución temporal
debug -> depurar
bundler -> ?

Copy link
Member

@carburo carburo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jpvg10 ! Thank you! I made some suggestions. Tell me what you think and we will ready to merge.

content/warnings/invalid-hook-call-warning.md Outdated Show resolved Hide resolved
content/warnings/invalid-hook-call-warning.md Outdated Show resolved Hide resolved
content/warnings/invalid-hook-call-warning.md Outdated Show resolved Hide resolved
content/warnings/invalid-hook-call-warning.md Outdated Show resolved Hide resolved
content/warnings/invalid-hook-call-warning.md Outdated Show resolved Hide resolved
content/warnings/invalid-hook-call-warning.md Outdated Show resolved Hide resolved
content/warnings/invalid-hook-call-warning.md Outdated Show resolved Hide resolved
content/warnings/invalid-hook-call-warning.md Outdated Show resolved Hide resolved
content/warnings/invalid-hook-call-warning.md Outdated Show resolved Hide resolved
content/warnings/invalid-hook-call-warning.md Outdated Show resolved Hide resolved
carburo and others added 11 commits February 11, 2019 21:32
Co-Authored-By: jpvg10 <juan.valencia10a@gmail.com>
Co-Authored-By: jpvg10 <juan.valencia10a@gmail.com>
Co-Authored-By: jpvg10 <juan.valencia10a@gmail.com>
Co-Authored-By: jpvg10 <juan.valencia10a@gmail.com>
Co-Authored-By: jpvg10 <juan.valencia10a@gmail.com>
Co-Authored-By: jpvg10 <juan.valencia10a@gmail.com>
Co-Authored-By: jpvg10 <juan.valencia10a@gmail.com>
Co-Authored-By: jpvg10 <juan.valencia10a@gmail.com>
Co-Authored-By: jpvg10 <juan.valencia10a@gmail.com>
Co-Authored-By: jpvg10 <juan.valencia10a@gmail.com>
Co-Authored-By: jpvg10 <juan.valencia10a@gmail.com>
@jpvg10
Copy link
Contributor Author

jpvg10 commented Feb 12, 2019

@carburo I agree with your suggestions!

But now I realize that I also translated the section identifiers in #138 . It has already been merged so I could do a new PR fixing that... Tell me what you think.

@carburo
Copy link
Member

carburo commented Feb 12, 2019

Yeah, I missed that 😅. Thank you for pointing it out. Already fixed it.
Very solid PR. Thank you again!

@carburo carburo merged commit 57bcddc into reactjs:master Feb 12, 2019
@jpvg10
Copy link
Contributor Author

jpvg10 commented Feb 14, 2019

@carburo Oh ok! Thanks to you 😄 glad to be able to make my small contribution to this project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants