Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate Code-Splitting #145

Merged
merged 6 commits into from Feb 15, 2019
Merged

Translate Code-Splitting #145

merged 6 commits into from Feb 15, 2019

Conversation

LuisRevillaM
Copy link
Contributor

Work in progress: translation of the Code-Splitting article in the Advanced Guides section.

@tesseralis tesseralis mentioned this pull request Feb 12, 2019
Closed
@LuisRevillaM LuisRevillaM changed the title WIP: Translate Code-Splitting Translate Code-Splitting Feb 13, 2019
@LuisRevillaM
Copy link
Contributor Author

Hi @carburo, this PR is ready for review. Thank you!

carburo
carburo approved these changes Feb 15, 2019
View reviewed changes
Copy link
Member

@carburo carburo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved the PR, just fixed a couple of typos. Great work! Thank you!

@carburo carburo merged commit a5f32c2 into reactjs:master Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carburo carburo carburo approved these changes

Assignees
No one assigned
Labels
has-reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LuisRevillaM @carburo @alejandronanez