Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing Hooks Spanish translation #156

Merged
merged 7 commits into from
Feb 18, 2019

Conversation

KevinGomezDev
Copy link
Contributor

Since there's not a current translation for Hooks FAQ, i used [Preguntas frecuentes acerca de Hooks] as a translation for Hooks FAQ

Copy link
Contributor

@icarlossz icarlossz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks! I left you some comments.

content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@Darking360 Darking360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greetings @KevinGomezDev and thanks for an amazing PR 🚀

I just left you some comments, must of them are just typos, accents and some word changes or order, also thanks for your items @icarlossz 💪 Read them, fix those and update the PR. Let me know for any questions.

Thanks once again 🥇

content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
@KevinGomezDev
Copy link
Contributor Author

KevinGomezDev commented Feb 18, 2019

@Darking360 @icarlossz Fixes were added on commits d48b938 and a21f526, let me know if there's something else missing or if it is ready to go.

@Darking360
Copy link
Collaborator

@KevinGomezDev Everything looks good for me. I just added a uppercase n for React Native and translate back to english the code example since we're doing those in english unless they are comments, I already pushed those so 🚀 Thanks again for the amazing work 🍺

@Darking360 Darking360 merged commit 0884335 into reactjs:master Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants