-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lists and Keys Translation #22
Conversation
content/docs/lists-and-keys.md
Outdated
|
||
Aqui esta una [explicacion en profundidad sobre porque las keys son necesarias](/docs/reconciliation.html#recursing-on-children) si estas interesado en aprender mas. | ||
Aquí esta una [explicación en profundidad sobre porque las keys son necesarias](/docs/reconciliation.html#recursing-on-children) si estas interesado en aprender más. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps Aquí hay
instead of Aquí está
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the original text it is Here is
, so for me it should be Aquí está
.
It should be Here there is
to be translated in Aquí hay
in my opinion. What do you think?
content/docs/lists-and-keys.md
Outdated
|
||
For example, if you [extract](/docs/components-and-props.html#extracting-components) a `ListItem` component, you should keep the key on the `<ListItem />` elements in the array rather than on the `<li>` element in the `ListItem` itself. | ||
Por ejemplo, si [extraes](/docs/components-and-props.html#extracting-components) un componente `ListItem`, debes mantener la key en el elemnto `<ListItem />` en el array en lugar de en el elemento `<li>` en el `ListItem` en si mismo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be better translated this way:
... debes mantener la key en los elementos
<ListItem />
en el array en lugar de en los elementos<li>
en elListItem
en sí.
Regardless of that, note elemnto
before <ListItem />
, it should be elemento/s
Note
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO
...derberias mantener la key en los elementos
<ListItem />
en el array en lugar de en el elemento<li>
en el<ListItem />
en si mismo.
Sounds better. What do you think?
content/docs/lists-and-keys.md
Outdated
|
||
**Ejemplo: Uso Incorrecto de Key** | ||
|
||
```javascript{4,5,14,15} | ||
function ListItem(props) { | ||
const value = props.value; | ||
return ( | ||
// Wrong! There is no need to specify the key here: | ||
// Mal! No es necesario especificar la key aquí: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My suggestion: // Mal! Aquí no es necesario especificar la key:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gariasf what about No hay necesidad de especificar la key
@@ -156,7 +156,7 @@ function ListItem(props) { | |||
function NumberList(props) { | |||
const numbers = props.numbers; | |||
const listItems = numbers.map((number) => | |||
// Wrong! The key should have been specified here: | |||
// Mal! La key debería haber sido especificada aquí: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My suggestion: // Mal! Aquí la key debería haber sido especificada:
@@ -177,14 +177,14 @@ ReactDOM.render( | |||
|
|||
```javascript{2,3,9,10} | |||
function ListItem(props) { | |||
// Correct! There is no need to specify the key here: | |||
// Correcto! No hay necesidad de especificar la key aquí: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My suggestion: // Correcto! Aquí no hay necesidad de especificar la key:
Hey! I left some reviews on the first commit and GitHub marks them as "outdated", but they are new nonetheless. |
I've done some corrections. Please tell me if there is something else to correct |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @EzequielMonforte. Judging by your comment I think you closed the PR by mistake. I made some suggestions and fix some typos. Thank you for your contribution!
Co-Authored-By: EzequielMonforte <ezequielmonforte@gmail.com>
Co-Authored-By: EzequielMonforte <ezequielmonforte@gmail.com>
Co-Authored-By: EzequielMonforte <ezequielmonforte@gmail.com>
Co-Authored-By: EzequielMonforte <ezequielmonforte@gmail.com>
Co-Authored-By: EzequielMonforte <ezequielmonforte@gmail.com>
Co-Authored-By: EzequielMonforte <ezequielmonforte@gmail.com>
Co-Authored-By: EzequielMonforte <ezequielmonforte@gmail.com>
Co-Authored-By: EzequielMonforte <ezequielmonforte@gmail.com>
Co-Authored-By: EzequielMonforte <ezequielmonforte@gmail.com>
Co-Authored-By: EzequielMonforte <ezequielmonforte@gmail.com>
Co-Authored-By: EzequielMonforte <ezequielmonforte@gmail.com>
Co-Authored-By: EzequielMonforte <ezequielmonforte@gmail.com>
Thanks @carburo ! I've applied some of your suggestions |
Looks good to me. Merging 🚀 |
#18
Need help translating words :
IDs, array, keys