Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hooks API Reference to spanish #35

Merged
merged 11 commits into from Feb 4, 2019
Merged

Hooks API Reference to spanish #35

merged 11 commits into from Feb 4, 2019

Conversation

jvelezpo
Copy link
Contributor

@jvelezpo jvelezpo commented Feb 1, 2019

Related to
#32

Is there is any typos please let me know 馃憤

EzequielMonforte and others added 3 commits February 1, 2019 19:10
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
EzequielMonforte and others added 5 commits February 1, 2019 19:15
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
Copy link
Member

@alejandronanez alejandronanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jvelezpo, this is getting closer, thanks for addressing all the changes!

One thing that I think we should decide before merging this is whether to reference the web page when we talk about dise帽o y pintura in line https://github.com/reactjs/es.reactjs.org/pull/35/files#diff-c38ef803fe7e7fc860f577c958440873R125 or not.

Another thing, let's go with Inicializaci贸n diferida instead of perezosa. Perezosa doesn't make much sense in this context.

content/docs/hooks-reference.md Outdated Show resolved Hide resolved
content/docs/hooks-reference.md Outdated Show resolved Hide resolved
content/docs/hooks-reference.md Show resolved Hide resolved
alejandronanez and others added 2 commits February 3, 2019 20:32
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
@alejandronanez alejandronanez merged commit 094fb9b into reactjs:master Feb 4, 2019
@alejandronanez
Copy link
Member

Hey @jvelezpo, thanks for your hard work! Welcome to the project! 馃帀

@jvelezpo
Copy link
Contributor Author

jvelezpo commented Feb 4, 2019

Hey @jvelezpo, thanks for your hard work! Welcome to the project! 馃帀

Awesome @alejandronanez i am looking forward to keep contributing

@jvelezpo jvelezpo deleted the HooksAPIReference branch February 12, 2019 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants