Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate hooks-state #60

Merged
merged 5 commits into from Feb 21, 2019
Merged

Translate hooks-state #60

merged 5 commits into from Feb 21, 2019

Conversation

a13marquez
Copy link
Contributor

@a13marquez a13marquez commented Feb 2, 2019

No description provided.

Copy link
Member

@alejandronanez alejandronanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @a13marquez, I see that some paragraphs are not being translated yet. I assume this PR is in WIP state still.

I updated the title of the PR to reflect this, once you're done, please, remove the WIP part of the title.

Ps. I didn't finish my review since this looks to be in progress.

@@ -28,11 +29,11 @@ function Example() {
}
```

We'll start learning about Hooks by comparing this code to an equivalent class example.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened to this line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed


If you used classes in React before, this code should look familiar:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, what happened to this one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@@ -56,15 +57,14 @@ class Example extends React.Component {
}
```

The state starts as `{ count: 0 }`, and we increment `state.count` when the user clicks a button by calling `this.setState()`. We'll use snippets from this class throughout the page.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to translate this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@alejandronanez alejandronanez changed the title Translate hooks-state WIP: Translate hooks-state Feb 3, 2019
@a13marquez
Copy link
Contributor Author

Yes, it is in progress, I forgot the WIP status, sorry. I will finish the translation and let you know

@a13marquez
Copy link
Contributor Author

And also I have a doubt about the comments inside the code. Should I translate them?

@carburo
Copy link
Member

carburo commented Feb 3, 2019

@a13marquez Yes, it is ok to translate comments, but not anything else inside code blocks.

@a13marquez a13marquez changed the title WIP: Translate hooks-state Translate hooks-state Feb 4, 2019
Copy link
Member

@alejandronanez alejandronanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @a13marquez, this is looking good, just left a minor comment that I think we should address before merging.

Also, it seems that we have merge conflicts, please, make sure to fix them too!

Thanks!!!

content/docs/hooks-state.md Outdated Show resolved Hide resolved
@netlify
Copy link

netlify bot commented Feb 21, 2019

Deploy preview for es-reactjs ready!

Built with commit db1a66b

https://deploy-preview-60--es-reactjs.netlify.com

@netlify
Copy link

netlify bot commented Feb 21, 2019

Deploy preview for es-reactjs ready!

Built with commit 2f9a7df

https://deploy-preview-60--es-reactjs.netlify.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants