Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation of State and Lifecycle #62

Merged
merged 6 commits into from Feb 3, 2019
Merged

Conversation

carburo
Copy link
Member

@carburo carburo commented Feb 3, 2019

Closes #62

Copy link
Member

@alejandronanez alejandronanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @carburo, this is looking good, you can merge it whenever you want.

Left a couple of questions though - they are not blocking this PR, but I think that are things that we should talk about down the road!

@@ -68,25 +68,25 @@ ReactDOM.render(
);
```

To implement this, we need to add "state" to the `Clock` component.
Para implementar esto, necesitamos agregar «estado» al componente `Clock`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No biggie, but I'm curious, why did you write «estado» instead of "estado"?

Copy link
Member Author

@carburo carburo Feb 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, "Spanish typography", the problem is that now I see this is not the norm everywhere. In Spain "Spanish" quotes are the norm but in some places like Mexico due to US influence (and also technology I guess), the most common are "English" quotes. In Cuba, for instance, Spanish quotes are used in books and media.
Any way can work I think. Once we arrive at a decision we should put in on the style guide and then make the appropriate changes in all the pages.

content/docs/state-and-lifecycle.md Show resolved Hide resolved
content/docs/state-and-lifecycle.md Show resolved Hide resolved
Copy link
Contributor

@icarlossz icarlossz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! I left you some comments 👍

content/docs/state-and-lifecycle.md Show resolved Hide resolved
content/docs/state-and-lifecycle.md Show resolved Hide resolved
content/docs/state-and-lifecycle.md Show resolved Hide resolved
@@ -409,41 +409,41 @@ Then you can update them independently with separate `setState()` calls:
}
```

The merging is shallow, so `this.setState({comments})` leaves `this.state.posts` intact, but completely replaces `this.state.comments`.
La fusión es superficial, asi que `this.setState({comments})` deja intacto a `this.state.posts`, pero remplaza completamente `this.state.comments`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reemplaza*

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, both are correct. But I will change it to "reemplaza" because it seems to be the "canonical" form.

@carburo carburo merged commit b38b7e6 into reactjs:master Feb 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants