Translate: Create a New React App #68
Conversation
Co-Authored-By: elyalvarado <elyalvarado@gmail.com>
Co-Authored-By: elyalvarado <elyalvarado@gmail.com>
There was a problem hiding this comment.
Hi, @elyalvarado. Thank you for your contribution. I made some suggestions before merging.
|
|
||
| This page describes a few popular React toolchains which help with tasks like: | ||
| Esta página describe algunas cadenas de herramientas de React populares, las cuales ayudan con tareas como: |
There was a problem hiding this comment.
| Esta página describe algunas cadenas de herramientas de React populares, las cuales ayudan con tareas como: | |
| Esta página describe algunas populares cadenas de herramientas de React, las cuales ayudan con tareas como: |
There was a problem hiding this comment.
The most common order for the adjective in Spanish is after the noun.
There was a problem hiding this comment.
Lo sé, pero hice la sugerencia porque la frase modificada por «populares» (cadenas de herramientas de React) hace un poco ambigua la frase: ¿Son populares las herramientas o las cadenas?
There was a problem hiding this comment.
In this case: "cadenas de herramientas de React" is the noun. Maybe the following wording is clearer:
- Esta página describe algunas de las cadenas de herramientas de React más populares ...
Co-Authored-By: elyalvarado <elyalvarado@gmail.com>
Co-Authored-By: elyalvarado <elyalvarado@gmail.com>
Co-Authored-By: elyalvarado <elyalvarado@gmail.com>
Co-Authored-By: elyalvarado <elyalvarado@gmail.com>
Co-Authored-By: elyalvarado <elyalvarado@gmail.com>
Co-Authored-By: elyalvarado <elyalvarado@gmail.com>
Co-Authored-By: elyalvarado <elyalvarado@gmail.com>
Co-Authored-By: elyalvarado <elyalvarado@gmail.com>
Co-Authored-By: elyalvarado <elyalvarado@gmail.com>
Co-Authored-By: elyalvarado <elyalvarado@gmail.com>
Co-Authored-By: elyalvarado <elyalvarado@gmail.com>
Co-Authored-By: elyalvarado <elyalvarado@gmail.com>
|
@carburo I added some of the changes you requested, but in some others I respectfully disagree. Please check the comments and let me know. |
|
Agree
… On Feb 5, 2019, at 2:48 PM, Rainer Martínez Fraga ***@***.***> wrote:
@carburo commented on this pull request.
In content/docs/create-a-new-react-app.md <#68 (comment)>:
>
-It sets up your development environment so that you can use the latest JavaScript features, provides a nice developer experience, and optimizes your app for production. You’ll need to have Node >= 6 and npm >= 5.2 on your machine. To create a project, run:
+**Create React App** configura tu ambiente de desarrollo de forma que puedas usar las últimas características de Javascript, brindando una buena experiencia de desarrollo, y optimizando tu aplicación para producción. Necesitarás tener Node >= 6 y npm >= 5.2 instalados en tu máquina. Para crear un proyecto ejecuta:
Yeah, I see your point. Then I would prefer to let it as before. What do you think?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#68 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAhSSDCkDfZ1MYHlNceKjFgV7FvswWbPks5vKd_wgaJpZM4ahRT8>.
|
|
Ok, I am going to squash and merge. Sorry, we do not have a proper style guide nor a contribution guide yet. We are working on it. |
Done with the translation for
Create a New React App#63.