Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate Context #78

Merged
merged 28 commits into from
Feb 21, 2019
Merged

Translate Context #78

merged 28 commits into from
Feb 21, 2019

Conversation

ricardoerl
Copy link
Contributor

@ricardoerl ricardoerl commented Feb 5, 2019 •
edited
Loading

Spanish translation of Context documentation.

Todo:

  • When to Use Context
  • Before You Use Context
  • API
    • React.createContext
    • Context.Provider
    • Class.contextType
    • Context.Consumer
  • Examples
    • Dynamic Context
    • Updating Context from a Nested Component
    • Consuming Multiple Contexts
  • Caveats
  • Legacy API

@tesseralis tesseralis mentioned this pull request Feb 5, 2019
Closed
@alejandronanez
Copy link
Member

Hey @ricardoerl, thanks for contributing!

Let us know if you need any help with this!

@ricardoerl ricardoerl changed the title [WIP] Translate Context Translate Context Feb 20, 2019
@netlify
Copy link

netlify bot commented Feb 20, 2019 •
edited
Loading

Deploy preview for es-reactjs ready!

Built with commit a93f0ab

https://deploy-preview-78--es-reactjs.netlify.com

@alejandronanez
Copy link
Member

Hey @ricardoerl I’ll take a look tonight, thanks!

@Darking360 Darking360 self-requested a review February 20, 2019 15:21
Darking360
Darking360 reviewed Feb 20, 2019
View reviewed changes
Copy link
Collaborator

@Darking360 Darking360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greetings @ricardoerl thanks you for a great PR! 🚀

I just left you some comments, a little parts that were not translated and one or two recommendations for a clearer reading 💪 Let me know for any questions, and when you update those we'll be good to go 🥇

Thanks a lot! 👍

content/docs/context.md Outdated Show resolved Hide resolved
examples/context/motivation-problem.js Outdated Show resolved Hide resolved
examples/context/motivation-solution.js Outdated Show resolved Hide resolved
content/docs/context.md Outdated Show resolved Hide resolved
content/docs/context.md Outdated Show resolved Hide resolved
content/docs/context.md Outdated Show resolved Hide resolved
examples/context/reference-caveats-problem.js Outdated Show resolved Hide resolved
examples/context/reference-caveats-solution.js Outdated Show resolved Hide resolved
content/docs/context.md Outdated Show resolved Hide resolved
content/docs/context.md Outdated Show resolved Hide resolved
Darking360 and others added 5 commits February 20, 2019 23:03
@Darking360 @ricardoerl
Update content/docs/context.md
2147ef0 
Co-Authored-By: ricardoerl <ricardo.ramirezlara@gmail.com>
@Darking360 @ricardoerl
Update examples/context/motivation-problem.js
a16f502 
Co-Authored-By: ricardoerl <ricardo.ramirezlara@gmail.com>
@Darking360 @ricardoerl
Update examples/context/motivation-solution.js
e503368 
Co-Authored-By: ricardoerl <ricardo.ramirezlara@gmail.com>
@Darking360 @ricardoerl
Update content/docs/context.md
9154138 
Co-Authored-By: ricardoerl <ricardo.ramirezlara@gmail.com>
@Darking360 @ricardoerl
Update content/docs/context.md
3e9f4ae 
Co-Authored-By: ricardoerl <ricardo.ramirezlara@gmail.com>
Darking360 and others added 5 commits February 20, 2019 23:06
@Darking360 @ricardoerl
Update content/docs/context.md
a2335d4 
Co-Authored-By: ricardoerl <ricardo.ramirezlara@gmail.com>
@Darking360 @ricardoerl
Update examples/context/reference-caveats-problem.js
b432a87 
Co-Authored-By: ricardoerl <ricardo.ramirezlara@gmail.com>
@Darking360 @ricardoerl
Update examples/context/reference-caveats-solution.js
05783aa 
Co-Authored-By: ricardoerl <ricardo.ramirezlara@gmail.com>
@Darking360 @ricardoerl
Update content/docs/context.md
38f914d 
Co-Authored-By: ricardoerl <ricardo.ramirezlara@gmail.com>
@Darking360 @ricardoerl
Update content/docs/context.md
0ec110c 
Co-Authored-By: ricardoerl <ricardo.ramirezlara@gmail.com>
@ricardoerl
Copy link
Contributor Author

@Darking360 changes approved. Thanks a lot for the help 🙌

@carburo
Copy link
Member

carburo commented Feb 21, 2019

The build is failing because you have long line comments in .js files. You should run Prettier.

@Darking360
Copy link
Collaborator

@ricardoerl Greetings! There are some changes left, maybe you didn't expand the selection of feedback, it has a Load more or Show other N conversations button. Please add those and then we'd be good to go 💪

Darking360 and others added 8 commits February 21, 2019 09:20
@Darking360 @ricardoerl
Update content/docs/context.md
8103089 
Co-Authored-By: ricardoerl <ricardo.ramirezlara@gmail.com>
@Darking360 @ricardoerl
Update content/docs/context.md
99b591e 
Co-Authored-By: ricardoerl <ricardo.ramirezlara@gmail.com>
@Darking360 @ricardoerl
Update content/docs/context.md
e6e95af 
Co-Authored-By: ricardoerl <ricardo.ramirezlara@gmail.com>
@Darking360 @ricardoerl
Update content/docs/context.md
89c617c 
Co-Authored-By: ricardoerl <ricardo.ramirezlara@gmail.com>
@Darking360 @ricardoerl
Update content/docs/context.md
a912a8b 
Co-Authored-By: ricardoerl <ricardo.ramirezlara@gmail.com>
@Darking360 @ricardoerl
Update content/docs/context.md
eaff519 
Co-Authored-By: ricardoerl <ricardo.ramirezlara@gmail.com>
@Darking360 @ricardoerl
Update content/docs/context.md
2e8c090 
Co-Authored-By: ricardoerl <ricardo.ramirezlara@gmail.com>
@Darking360 @ricardoerl
Update examples/context/theme-detailed-app.js
a93f0ab 
Co-Authored-By: ricardoerl <ricardo.ramirezlara@gmail.com>
Darking360
Darking360 approved these changes Feb 21, 2019
View reviewed changes
Copy link
Collaborator

@Darking360 Darking360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ricardoerl looks great for me! Thanks for the amazing work! 🚀

@Darking360 Darking360 merged commit 6aae81b into reactjs:master Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darking360 Darking360 Darking360 approved these changes

Assignees
No one assigned
Labels
changes-requested has-reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ricardoerl @alejandronanez @carburo @Darking360