Translate: Environment Requirements #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
angelitaooo
commented
Feb 6, 2019
angelitaooo
commented
Relates to #4
alejandronanez
requested changes
Feb 6, 2019
There was a problem hiding this comment.
Hey @angelitaooo,
Congratulations for sending your first PR - this is looking good so far, I left a couple of minor changes that you should address in order to approve this PR.
Let us know when it's ready!
Thanks!
|
@alejandronanez the changes were easy enough I went ahead and did them myself. 🙂Will you take a look? |
|
@alejandronanez Seems fine for me, it is a small page. I just fixed a typo (collección -> colección) and the inconsistent use of 'environment' (once as 'ambiente', once as 'entorno'). There is another small issue with the use of 'soportar' for tranlationg 'support', but I think we can leave that to the style guide. For me, it's ready to be merged. |
|
Say no more @carburo! Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.