Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translation of Sharing State Between Components #357 #360

Merged
merged 2 commits into from Sep 29, 2023

Conversation

Ehsan-Yari
Copy link

@rezvani2647
Copy link
Member

rezvani2647 commented Sep 28, 2023

please remove unnecessarily div or any other tags and upadte this PR.
we should not add something to the file we only change the contents to Farsi.

thank you for your time. :-)

@Ehsan-Yari
Copy link
Author

@rezvani2647 sorry about that.i thought i should wrap all paragraphs with div and give them RTL direction.
i removed all div containers and RTL styles as you said so my commit only contains the translation
thanks <3

@rezvani2647
Copy link
Member

@rezvani2647 sorry about that.i thought i should wrap all paragraphs with div and give them RTL direction. i removed all div containers and RTL styles as you said so my commit only contains the translation thanks <3

wonderful. 😍
Please, there's no need to sorry, you didn't do anything to sorry for. you've just done a great service. 🙏

@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@rezvani2647 rezvani2647 merged commit 60b2ab8 into reactjs:main Sep 29, 2023
3 of 4 checks passed
@Ehsan-Yari
Copy link
Author

Ehsan-Yari commented Sep 29, 2023

@rezvani2647 thanks a lot.it was my pleasure to help.btw can you plase add me to contributors list ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants