Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated faq-structure #54

Closed
wants to merge 12 commits into from
Closed

Updated faq-structure #54

wants to merge 12 commits into from

Conversation

aliana17
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Oct 11, 2019

Deploy preview for hi-reactjs ready!

Built with commit bd71fa6

https://deploy-preview-54--hi-reactjs.netlify.com

@arshadkazmi42
Copy link
Member

arshadkazmi42 commented Oct 12, 2019

@anchal7299 Looks like your fork is very old. Can you update your fork repo with latest commits of this repo.
You can check this Sync Fork, on how to do that

@aliana17
Copy link
Contributor Author

aliana17 commented Oct 12, 2019 via email

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work with the translations.
I have added couple of feedbacks.
Its good to go from my end after those fixes

content/docs/faq-structure.md Outdated Show resolved Hide resolved
content/docs/faq-structure.md Outdated Show resolved Hide resolved
content/docs/faq-structure.md Outdated Show resolved Hide resolved
content/docs/faq-structure.md Outdated Show resolved Hide resolved
content/docs/faq-structure.md Outdated Show resolved Hide resolved
content/docs/faq-structure.md Outdated Show resolved Hide resolved

If you're just starting a project, [don't spend more than five minutes](https://en.wikipedia.org/wiki/Analysis_paralysis) on choosing a file structure. Pick any of the above approaches (or come up with your own) and start writing code! You'll likely want to rethink it anyway after you've written some real code.
यदि आप एक प्रोजेक्ट शुरू कर रहें हैं, तो फ़ाइल संरचना चुनने के लिए [पांच मिनट से अधिक समय न लगाएं।](https://en.wikipedia.org/wiki/Analysis_paralysis)
उपरोक्त किसी भी दृष्टिकोण को चुनें (या अपने स्वयं के साथ आएं) और कोड लिखना शुरू करें! आपके द्वारा कुछ वास्तविक कोड लिखे जाने के बाद, आप इसे वैसे भी पुनर्विचार करना चाहेंगे।
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this line break

content/docs/faq-structure.md Outdated Show resolved Hide resolved
content/docs/faq-structure.md Outdated Show resolved Hide resolved
content/docs/faq-structure.md Outdated Show resolved Hide resolved
Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. 💯
I have added suggestion for 1 fix, which does not looks correct.
Everything else looks good


If you're just starting a project, [don't spend more than five minutes](https://en.wikipedia.org/wiki/Analysis_paralysis) on choosing a file structure. Pick any of the above approaches (or come up with your own) and start writing code! You'll likely want to rethink it anyway after you've written some real code.
यदि आप एक प्रोजेक्ट शुरू कर रहें हैं, तो फ़ाइल संरचना चुनने के लिए [पांच मिनट से अधिक समय न लगाएं](https://en.wikipedia.org/wiki/Analysis_paralysis) ।
उपरोक्त किसी भी दृष्टिकोण को चुनें (या अपने स्वयं के साथ आएं) और कोड लिखना शुरू करें! आपके द्वारा कुछ वास्तविक कोड लिखे जाने के बाद, आप इसे वैसे भी पुनर्विचार करना चाहेंगे।
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

यदि आप एक प्रोजेक्ट शुरू कर रहें हैं, तो फ़ाइल संरचना चुनने के लिए [पांच मिनट से अधिक समय न लगाएं](https://en.wikipedia.org/wiki/Analysis_paralysis) । 
उपरोक्त किसी भी दृष्टिकोण को चुनें (या अपने स्वयं के साथ आएं) और कोड लिखना शुरू करें! आपके द्वारा कुछ वास्तविक कोड लिखे जाने के बाद, आप इसे वैसे भी पुनर्विचार करना चाहेंगे।

=>

यदि आप एक प्रोजेक्ट शुरू कर रहें हैं, तो फ़ाइल संरचना चुनने के लिए [पांच मिनट से अधिक समय न लगाएं](https://en.wikipedia.org/wiki/Analysis_paralysis)। उपरोक्त किसी भी दृष्टिकोण को चुनें (या अपने स्वयं के साथ आएं) और कोड लिखना शुरू करें! आपके द्वारा कुछ वास्तविक कोड लिखे जाने के बाद, आप इसे वैसे भी पुनर्विचार करना चाहेंगे।

Line 70 and 71 should in single line
Line 71 should be line break
Line 72 should be a new line

@aliana17
Copy link
Contributor Author

aliana17 commented Nov 1, 2019 via email

@arshadkazmi42
Copy link
Member

@anchal7299 Looks like I missed this with my other mails.
I just looked into it, looks like there is some issue with the PR, its showing alot of commits which should not be here.
Can you do the below steps

  • git remote add upstream https://github.com/reactjs/hi.reactjs.org.git
  • git pull upstream master --rebase
  • git push origin master --force

It this does not work, we might have to open a new PR.

@arshadkazmi42
Copy link
Member

Closing due to inactivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants