Translate Hooks FAQ #123
Translate Hooks FAQ #123
Conversation
|
Deploy preview for idreactjs ready! Built with commit fa44738 |
|
Deploy preview for id-reactjs ready! Built with commit fa44738 |
There was a problem hiding this comment.
@dummyeuy Thanks! This is my first pass for the review. Will look into it again later tonight.
There some more issues littered across the translation that I didn't put in as a suggested change. Please look into them:
- Please note the ordering of nouns and adjectives between English and Bahasa Indonesia. In many cases, they need to be swapped around. (e.g. DOM element -> elemen DOM)
- Names that reference features within React (e.g. React DOM, React Hooks, etc) don't need to be italicised
- If you use Hooks on its own, you can italicise it, but if used together with React (e.g. React Hooks), no need to be italicised.
- Abbreviations in foreign languages need not be italicised. Reference: https://twitter.com/ivanlanin/status/898520073224167424
- Function/method names inside code blocks (e.g.
useState,componentDidMount) don't need to be italicised.
|
Dear @resir014 my latest commit as you can see on https://github.com/reactjs/id.reactjs.org/pull/123/files/b293ec3a432e9bd035f16b07b719b873d108c2e0 is up. This is according to your feedback today (11.00 A.M, Oct 25). I don't need to create new Thank you |
|
@dummyeuy You do not need to close the pull request, as you can continue making changes here until everything is good. |
Do I need to reopen this pull request? |
|
Yes. |
If you don't know how to remove the commit history to delete the Hooks FAQ file, then you can just close that PR and reopen. I'll only merge completed PRs. |
@resir014 |
I've already closed Hooks API PR and I can't reopen the PR because of the JSX-in-depth PR is still open -not merged yet |
… minor typos in jsx-in-depth. So this commint/PR will focus on JSX-in-depth.md according to reactjs#125 (comment)
…src/CodeEditor/CodeEditor copy.js from the latest commit according to reactjs#125 (review)
|
Excuse me @resir014 , do I have to make a change in this PR too? |
|
@dummyeuy I'm not sure I understand your question 😅 What do you mean by that? |
Yes. However, on a1a815e, I see that you've deleted your work on the Hooks FAQ page and replaced it with the merged translation from the other PR (JSX in-depth). I don't understand what you're doing here 😅 |
Hello @resir014 , I brought back my deleted work on Hooks FAQ before the JSX-in-depth PR. You may check it out and review the translated version of Hooks FAQ on my latest commit Thank you |
dummyeuy
changed the title
There was a problem hiding this comment.
Here's my first pass of the review (up to the Adoption Strategy section). There are some issues to address beyond all the suggested changes:
1.
Please remove all italicisation of abbreviations of names (e.g. API, DOM). Abbreviations for foreign names don't need to be translated. https://twitter.com/ivanlanin/status/898520073224167424
2.
In all code syntax blocks, please remove the spaces between the language name and line numbers.
This breaks syntax highlighting on the final rendered page.
|
Thank you @resir014 for your review and suggested changes.
Please kindly review my latest commit :) |
There was a problem hiding this comment.
Finished review for the second half of the page. Please take a look @dummyeuy.
- Please also don't forget to re-check each headings inside the table of contents, and the actual headings themselves. Make sure there are no differences between them.
|
All suggested corrections are applied, and the headings & table of contents are also updated. |
resir014
changed the title
Translating content/docs/hooks-faq.md by dummyeuy with minor revisions
Referenced from this #1 (comment)