Translate JSX In-Depth #125

dummyeuy · 2019-10-28T08:26:08Z

Greetings.

My latest commit on dummyeuy@296003d (03.00 P.M, Oct 28) as you can see is my translation result of JSX in-depth (as you assigned me on #1 (comment)).

Please kindly review it.

Thank you

…y own observation) according to https://github.com/reactjs/id.reactjs.org/pull/123/files/b293ec3a432e9bd035f16b07b719b873d108c2e0

netlify · 2019-10-28T08:29:41Z

Deploy preview for idreactjs ready!

Built with commit 092a8e7

https://deploy-preview-125--idreactjs.netlify.com

netlify · 2019-10-28T08:31:49Z

Deploy preview for id-reactjs ready!

Built with commit 24d15c7

https://deploy-preview-125--id-reactjs.netlify.com

bangun-jds

Some typing errors

content/docs/hooks-faq.md

bangun-jds

Some typing errors

dummyeuy

Some typing errors

I've applied the corrections you gave.
Please kindly review it.

…#125 (review)

dummyeuy · 2019-10-30T05:01:56Z

Some typing errors

dear @bangunbagustapa I've applied the corrections you gave.
Latest commit on dummyeuy@f2c364a

Please kindly review it.

resir014

Hi @dummyeuy, I see you also included your existing translation for Hooks FAQ which was originally done in this pull request.

Please keep them on separate pull requests. Doing 1 page per pull request makes it easier for us to track the translation progress. Thank you.

content/docs/jsx-in-depth.md

dummyeuy · 2019-10-31T00:55:40Z

Hi @dummyeuy, I see you also included your existing translation for Hooks FAQ which was originally done in this pull request.

Please keep them on separate pull requests. Doing 1 page per pull request makes it easier for us to track the translation progress. Thank you.

I'm sorry, it was my bad. I was so excited to translate more than just 1 page in short time period - so I choosed to translate JSX-in-depth right after Hooks-FAQ.

bangun-jds · 2019-10-31T07:43:43Z

@dummyeuy I think you should seperate your PR first before it can be reviewed by maintainers.

resir014 · 2019-11-08T08:21:08Z

@dummyeuy yes, @bangunbagustapa is correct. Please do so.

dummyeuy · 2019-11-08T11:46:37Z

@dummyeuy yes, @bangunbagustapa is correct. Please do so.

so, I need to make the Hooks FAQ file back to its default/original file, then I re-commit?
Or how?

… minor typos in jsx-in-depth. So this commint/PR will focus on JSX-in-depth.md according to reactjs#125 (comment)

dummyeuy · 2019-11-12T05:01:23Z

Hello @resir014 , I've done the "separation" by change the hooks-faq.md file back to its original/default, so this PR will focus only on jsx-in-depth.md.
As you can see on my latest commit

Please, kindly review it

resir014

Thanks for removing the translations not contextual to this PR. However, you added even more changes that doesn't seem to be relevant to here. Please revert those changes as well. 😅

Note that you only need to update the Markdown files for these translations. Make sure no other files are staged before you commit.

src/components/CodeEditor/CodeEditor copy.js

.eslintignore

.gitignore

…src/CodeEditor/CodeEditor copy.js from the latest commit according to reactjs#125 (review)

dummyeuy · 2019-11-14T04:38:16Z

Thanks for removing the translations not contextual to this PR. However, you added even more changes that doesn't seem to be relevant to here. Please revert those changes as well. 😅

Note that you only need to update the Markdown files for these translations. Make sure no other files are staged before you commit.

Hello @resir014 I've resolved the corrections you gave, as you can check on my lattest commit.
Please, kindly review it :)

resir014

Thanks @dummyeuy, I have reviewed the first half of the page. Among the tiny translation fixes, there are still two overall issues:

The code block syntax has these optional brackets {} to indicate highlighted lines:

Please do not add the spaces between the js and the brackets {}, as this will break with syntax highlighting.

Also across the page, the word "children" is translated to "turunan". Let's keep this consistent with other pages by not translating them (children).

Please address these first, then I'll take a look at the second half of the pages. Thank you!

content/docs/jsx-in-depth.md

…eactjs#125 (review)

dummyeuy · 2019-11-14T09:55:55Z

Thanks @dummyeuy, I have reviewed the first half of the page. Among the tiny translation fixes, there are still two overall issues:

The code block syntax has these optional brackets {} to indicate highlighted lines:

Please do not add the spaces between the js and the brackets {}, as this will break with syntax highlighting.

Also across the page, the word "children" is translated to "turunan". Let's keep this consistent with other pages by not translating them (children).

Please address these first, then I'll take a look at the second half of the pages. Thank you!

Thank you for kind reviews.
The only reason I added space between js and the brackets {} was, so I could differentiate the syntax between the code blocks -- it was easier to see the colors tho 😅

Your corrections at first-half review are applied, as you can see on my lattest commit

Thank you again @resir014

resir014

Sorry I just checked this PR again after a few days, been busy.

This is now good to go. Thank you so much for your help!

dummyeuy · 2019-12-02T11:02:09Z

Sorry I just checked this PR again after a few days, been busy.

This is now good to go. Thank you so much for your help!

Thank you for coming back.

You're welcome

* hasil terjemahan content/docs/HOOKS-FAQ.md dari dummyeuy * Translating content/docs/hooks-faq.md by dummyeuy with minor revisions * Translating content/docs/hooks-faq.md by dummyeuy with minor revisions * all suggested revisions are applied plus some minor revisions (from my own observation) according to https://github.com/reactjs/id.reactjs.org/pull/123/files/b293ec3a432e9bd035f16b07b719b873d108c2e0 * commit hasil translasi JSX-in-depth sesuai dengan #1 (comment) * corrections of 'some typing errors' are applied, according to #125 (review) * applied minor revisions according to #125 (comment) * Change the hooks-faq.md back to its default/original and revised some minor typos in jsx-in-depth. So this commint/PR will focus on JSX-in-depth.md according to #125 (comment) * change back .eslintignore and .gitignore to their default and remove src/CodeEditor/CodeEditor copy.js from the latest commit according to #125 (review) * revisions are applied from first-half of the page review according to #125 (review) * remove stray whitespace in .eslintignore * remove additional accidental whitespace * bring back the previous deleted work on Hooks FAQ, according to #123 (comment) * resolved all suggested changes according to #123 (review) Co-authored-by: Resi Respati <resir014@gmail.com>

dummyeuy added 5 commits October 25, 2019 03:07

hasil terjemahan content/docs/HOOKS-FAQ.md dari dummyeuy

6329e84

Translating content/docs/hooks-faq.md by dummyeuy with minor revisions

ce2f15a

Translating content/docs/hooks-faq.md by dummyeuy with minor revisions

b293ec3

all suggested revisions are applied plus some minor revisions (from m…

594a1fc

…y own observation) according to https://github.com/reactjs/id.reactjs.org/pull/123/files/b293ec3a432e9bd035f16b07b719b873d108c2e0

commit hasil translasi JSX-in-depth sesuai dengan reactjs#1 (comment)

296003d

bangun-jds reviewed Oct 29, 2019

View reviewed changes

dummyeuy commented Oct 30, 2019

View reviewed changes

corrections of 'some typing errors' are applied, according to reactjs…

f2c364a

…#125 (review)

resir014 requested changes Oct 30, 2019

View reviewed changes

content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved

tesseralis mentioned this pull request Oct 30, 2019

[OLD] Legacy Indonesian Translation Progress #1

Closed

96 tasks

applied minor revisions according to reactjs#125 (comment)

66e906a

dummyeuy mentioned this pull request Nov 3, 2019

Translate Hooks FAQ #123

Merged

Change the hooks-faq.md back to its default/original and revised some…

a1a815e

… minor typos in jsx-in-depth. So this commint/PR will focus on JSX-in-depth.md according to reactjs#125 (comment)

resir014 requested changes Nov 13, 2019

View reviewed changes

src/components/CodeEditor/CodeEditor copy.js Outdated Show resolved Hide resolved

.eslintignore Outdated Show resolved Hide resolved

.gitignore Outdated Show resolved Hide resolved

change back .eslintignore and .gitignore to their default and remove …

b0787ba

…src/CodeEditor/CodeEditor copy.js from the latest commit according to reactjs#125 (review)

resir014 requested changes Nov 14, 2019

View reviewed changes

revisions are applied from first-half of the page review according to r…

62d3f9b

…eactjs#125 (review)

resir014 approved these changes Dec 2, 2019

View reviewed changes

remove stray whitespace in .eslintignore

092a8e7

remove additional accidental whitespace

24d15c7

resir014 changed the title ~~Translation result of JSX in-depth by dummyeuy as assigned on https://github.com/reactjs/id.reactjs.org/issues/1#issuecomment-546177857~~ Translate JSX In-Depth Dec 2, 2019

resir014 merged commit afd51c9 into reactjs:master Dec 2, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Translate JSX In-Depth #125

Translate JSX In-Depth #125

dummyeuy commented Oct 28, 2019

netlify bot commented Oct 28, 2019 •

edited

netlify bot commented Oct 28, 2019 •

edited

bangun-jds left a comment

bangun-jds left a comment

dummyeuy left a comment

dummyeuy commented Oct 30, 2019

resir014 left a comment

dummyeuy commented Oct 31, 2019

bangun-jds commented Oct 31, 2019 •

edited

resir014 commented Nov 8, 2019

dummyeuy commented Nov 8, 2019

dummyeuy commented Nov 12, 2019

resir014 left a comment

dummyeuy commented Nov 14, 2019

resir014 left a comment

dummyeuy commented Nov 14, 2019

resir014 left a comment

dummyeuy commented Dec 2, 2019

Translate JSX In-Depth #125

Translate JSX In-Depth #125

Conversation

dummyeuy commented Oct 28, 2019

netlify bot commented Oct 28, 2019 • edited

netlify bot commented Oct 28, 2019 • edited

bangun-jds left a comment

Choose a reason for hiding this comment

bangun-jds left a comment

Choose a reason for hiding this comment

dummyeuy left a comment

Choose a reason for hiding this comment

dummyeuy commented Oct 30, 2019

resir014 left a comment

Choose a reason for hiding this comment

dummyeuy commented Oct 31, 2019

bangun-jds commented Oct 31, 2019 • edited

resir014 commented Nov 8, 2019

dummyeuy commented Nov 8, 2019

dummyeuy commented Nov 12, 2019

resir014 left a comment

Choose a reason for hiding this comment

dummyeuy commented Nov 14, 2019

resir014 left a comment

Choose a reason for hiding this comment

dummyeuy commented Nov 14, 2019

resir014 left a comment

Choose a reason for hiding this comment

dummyeuy commented Dec 2, 2019

netlify bot commented Oct 28, 2019 •

edited

netlify bot commented Oct 28, 2019 •

edited

bangun-jds commented Oct 31, 2019 •

edited