Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Test Utilities Page #16

Merged
merged 11 commits into from Mar 3, 2019
Merged

Translate Test Utilities Page #16

merged 11 commits into from Mar 3, 2019

Conversation

Lukereonal
Copy link
Contributor

Mohon reviewnya guys 🙏🏻

Copy link
Contributor

@itsnotrisky itsnotrisky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refer to this discussion once it is added to glossary.

content/docs/addons-test-utils.md Outdated Show resolved Hide resolved
Copy link
Member

@regalius regalius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like just need to adjust several common terms and we're good to go 🎉

content/docs/addons-test-utils.md Outdated Show resolved Hide resolved
content/docs/addons-test-utils.md Outdated Show resolved Hide resolved
Copy link
Member

@regalius regalius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 last thing mas @Lukereonal , please translate strings inside code blocks to make it uniform across pages and I think, we're good to go 👍

@Lukereonal
Copy link
Contributor Author

@regalius sorry i missed that, I already translate the string 🙏🏻

@regalius
Copy link
Member

Sorry, noticed another thing mas @Lukereonal , capitalized Anda (and other kata sapaan) should only be in the context of kata sapaan, so:

  • Anda harus melakukan ...
  • ...membuat komponen anda

Because in the case of no. 2 anda is attached to the noun as kepemilikan, so it's not necessary to capitalize it 😄

@Lukereonal
Copy link
Contributor Author

@regalius Thanks for the input, I already change some Anda that i think is supposed to be a noun. But please check again because i'm not 100% sure especially the last Anda on the page 😅

Copy link
Member

@regalius regalius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM from me @Lukereonal ! Thank you so much for the hardwork 🎉

@gedeagas @arfianadam any comments before we're merging this PR?

content/docs/addons-test-utils.md Outdated Show resolved Hide resolved
content/docs/addons-test-utils.md Outdated Show resolved Hide resolved
content/docs/addons-test-utils.md Outdated Show resolved Hide resolved
content/docs/addons-test-utils.md Outdated Show resolved Hide resolved
content/docs/addons-test-utils.md Outdated Show resolved Hide resolved
content/docs/addons-test-utils.md Outdated Show resolved Hide resolved
content/docs/addons-test-utils.md Outdated Show resolved Hide resolved
content/docs/addons-test-utils.md Outdated Show resolved Hide resolved
@Lukereonal
Copy link
Contributor Author

@arfianadam Thanks for the review, I already fix it please let me know if there anything else 🙏🏻

@netlify
Copy link

netlify bot commented Feb 18, 2019

Deploy preview for idreactjs ready!

Built with commit 8533b7a

https://deploy-preview-16--idreactjs.netlify.com

@regalius
Copy link
Member

This PR looks like it's ready to be merged what do you think guys? @gedeagas @arfianadam

@netlify
Copy link

netlify bot commented Feb 25, 2019

Deploy preview for id-reactjs ready!

Built with commit 8533b7a

https://deploy-preview-16--id-reactjs.netlify.com

@regalius regalius merged commit 4547fd1 into reactjs:master Mar 3, 2019
@regalius
Copy link
Member

regalius commented Mar 3, 2019

It got LGTM from @arfianadam & @gedeagas, and merged. Thanks for the contribution mas @Lukereonal ! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants