Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Shallow Renderer #18

Merged
merged 9 commits into from Sep 23, 2019

Conversation

riandy-dimas
Copy link
Contributor

I have done translating this section, kindly review it 馃檹

@riandy-dimas riandy-dimas changed the title translate shallow renderer Translate Shallow Renderer Feb 11, 2019
Copy link
Contributor

@itsnotrisky itsnotrisky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refer to this discussion once it is added to glossary.

content/docs/addons-shallow-renderer.md Outdated Show resolved Hide resolved
Co-Authored-By: riandy-dimas <riandy.banimahendra@airyrooms.com>
Copy link
Member

@regalius regalius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good enough but there's several sentence that can be improved, what do you think? 馃槃

content/docs/addons-shallow-renderer.md Outdated Show resolved Hide resolved
content/docs/addons-shallow-renderer.md Outdated Show resolved Hide resolved
content/docs/addons-shallow-renderer.md Outdated Show resolved Hide resolved
@netlify
Copy link

netlify bot commented Feb 19, 2019

Deploy preview for idreactjs ready!

Built with commit 3efba65

https://deploy-preview-18--idreactjs.netlify.com

Copy link
Member

@regalius regalius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from me.. Thanks for the contribution @riandy-dimas ! 馃帀

@arfianadam @gedeagas any comments?

@netlify
Copy link

netlify bot commented Mar 8, 2019

Deploy preview for id-reactjs ready!

Built with commit 3efba65

https://deploy-preview-18--id-reactjs.netlify.com

@resir014 resir014 merged commit 286c822 into reactjs:master Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants