Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Rules of Hooks #53

Merged
merged 1 commit into from Sep 3, 2019
Merged

Conversation

anggras
Copy link
Contributor

@anggras anggras commented Mar 4, 2019

Done!

Please help with the review. Cheers!

@netlify
Copy link

netlify bot commented Mar 4, 2019

Deploy preview for idreactjs ready!

Built with commit f9084be

https://deploy-preview-53--idreactjs.netlify.com

@netlify
Copy link

netlify bot commented Mar 4, 2019

Deploy preview for id-reactjs ready!

Built with commit f9084be

https://deploy-preview-53--id-reactjs.netlify.com

@gedeagas
Copy link
Member

gedeagas commented Mar 5, 2019

Awesome @anggras, i will check this later today. Thank you for contributing

@grikomsn grikomsn changed the title Translated Rules of Hooks Translate Rules of Hooks Jul 10, 2019
@@ -6,33 +6,33 @@ next: hooks-custom.html
prev: hooks-effect.html
---

*Hooks* are a new addition in React 16.8. They let you use state and other React features without writing a class.
*Hooks* adalah sebuah fitur tambahan baru di React 16.8. Mereka membantu Anda untuk menggunakan *state* and fitur-fitur React lainnya tanpa menulis sebuah kelas.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and other Hooks-related pages have the same English sentence, but various contributors have their own version of translation. Here are PR diffs related to Hooks:

  • Diff for Using the State Hook (Translate Using the State Hook #28):

    - *Hooks* are a new addition in React 16.8. They let you use state and other React features without writing a class.
    + *Hooks* merupakan fitur baru di React 16.8. Fitur ini memungkinkan Anda menggunakan *state* dan fitur React lainnya tanpa menuliskan sebuah kelas.
  • Diff for Using the Effect Hook (Translate Using the Effect Hook #38):

    - *Hooks* are a new addition in React 16.8. They let you use state and other React features without writing a class.
    + *Hooks* adalah tambahan baru di React 16.8. *Hooks* memungkinkan Anda dapat menggunakan *state* dan fitur lain di *React* tanpa menulis *class*.
  • Diff for Hooks at a Glance (merged) (Translate Hooks at a Glance #88):

    - *Hooks* are a new addition in React 16.8. They let you use state and other React features without writing a class.
    + *Hooks* merupakan penambahan baru pada React 16.8. *Hooks* memungkinkan Anda menggunakan *state* dan fitur React lainnya tanpa membuat sebuah kelas.

I suggest we open an issue discussing whether we should sync the translations or just stick to the contributors' version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grikomsn +1 for making the translations consistent. I'll go with the first one IMO.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which first one? If #28, #88 or a new related PR will be opened to update "Hooks at a Glance" translation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah sorry @grikomsn, when I said "the first" I mean the first in that list 😅 so the one in #28.

@resir014
Copy link
Member

resir014 commented Sep 3, 2019

I'll merge this page for now. Untuk komen @grikomsn soal penyeragaman deskripsi Hooks akan dilakukan setelah semua terjemahan halaman Hooks di-merge.

@resir014 resir014 merged commit 2cd781e into reactjs:master Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants