Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs:Basic - Lifting State Up #6

Merged
merged 5 commits into from Mar 19, 2019

Conversation

mendoanjoe
Copy link
Contributor

No description provided.

content/docs/lifting-state-up.md Outdated Show resolved Hide resolved
content/docs/lifting-state-up.md Outdated Show resolved Hide resolved
content/docs/lifting-state-up.md Outdated Show resolved Hide resolved
content/docs/lifting-state-up.md Outdated Show resolved Hide resolved
content/docs/lifting-state-up.md Outdated Show resolved Hide resolved
content/docs/lifting-state-up.md Outdated Show resolved Hide resolved
content/docs/lifting-state-up.md Outdated Show resolved Hide resolved
content/docs/lifting-state-up.md Outdated Show resolved Hide resolved
content/docs/lifting-state-up.md Outdated Show resolved Hide resolved
content/docs/lifting-state-up.md Outdated Show resolved Hide resolved
content/docs/lifting-state-up.md Outdated Show resolved Hide resolved
content/docs/lifting-state-up.md Outdated Show resolved Hide resolved
content/docs/lifting-state-up.md Outdated Show resolved Hide resolved
content/docs/lifting-state-up.md Outdated Show resolved Hide resolved
content/docs/lifting-state-up.md Outdated Show resolved Hide resolved
content/docs/lifting-state-up.md Outdated Show resolved Hide resolved
content/docs/lifting-state-up.md Outdated Show resolved Hide resolved
content/docs/lifting-state-up.md Outdated Show resolved Hide resolved
content/docs/lifting-state-up.md Outdated Show resolved Hide resolved
content/docs/lifting-state-up.md Outdated Show resolved Hide resolved
content/docs/lifting-state-up.md Outdated Show resolved Hide resolved
content/docs/lifting-state-up.md Outdated Show resolved Hide resolved
content/docs/lifting-state-up.md Outdated Show resolved Hide resolved
content/docs/lifting-state-up.md Outdated Show resolved Hide resolved
@regalius
Copy link
Member

Hi @mendoanjoe I've noticed there had been no activities on this PR since 3 days ago, do you still wants to continue to do it or should I release it to someone who wants to continue on translating this page? Thanks!

content/docs/lifting-state-up.md Outdated Show resolved Hide resolved
content/docs/lifting-state-up.md Outdated Show resolved Hide resolved
content/docs/lifting-state-up.md Outdated Show resolved Hide resolved
content/docs/lifting-state-up.md Outdated Show resolved Hide resolved
@gedeagas
Copy link
Member

Hi @mendoanjoe, we still count on your contribution.
Keep the spirit, you can do it 💪.

@mendoanjoe
Copy link
Contributor Author

Hi @mendoanjoe, we still count on your contribution.
Keep the spirit, you can do it .

I am so sorry, I will update on Saturday 😄

@netlify
Copy link

netlify bot commented Feb 19, 2019

Deploy preview for idreactjs ready!

Built with commit 328841b

https://deploy-preview-6--idreactjs.netlify.com

@netlify
Copy link

netlify bot commented Feb 19, 2019

Deploy preview for idreactjs ready!

Built with commit 8d7f6f3

https://deploy-preview-6--idreactjs.netlify.com

@tesseralis
Copy link
Member

@mendoanjoe is this ready for another review?

@mendoanjoe
Copy link
Contributor Author

@tesseralis ready

Copy link
Member

@regalius regalius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mendoanjoe , ada beberapa typo & translasi yang sepertinya perlu disesuaikan agar lebih pas dengan maksud sebenarnya dari versi English-nya, setelah itu harusnya sudah oke 🎉

content/docs/lifting-state-up.md Show resolved Hide resolved
content/docs/lifting-state-up.md Outdated Show resolved Hide resolved
content/docs/lifting-state-up.md Outdated Show resolved Hide resolved
content/docs/lifting-state-up.md Outdated Show resolved Hide resolved
content/docs/lifting-state-up.md Outdated Show resolved Hide resolved
content/docs/lifting-state-up.md Outdated Show resolved Hide resolved
content/docs/lifting-state-up.md Outdated Show resolved Hide resolved
content/docs/lifting-state-up.md Outdated Show resolved Hide resolved
content/docs/lifting-state-up.md Outdated Show resolved Hide resolved
content/docs/lifting-state-up.md Outdated Show resolved Hide resolved
@netlify
Copy link

netlify bot commented Mar 6, 2019

Deploy preview for id-reactjs ready!

Built with commit 8d7f6f3

https://deploy-preview-6--id-reactjs.netlify.com

Copy link
Member

@regalius regalius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from me, thanks for the contribution @mendoanjoe ! 🎉

Any comment guys? @arfianadam @gedeagas @rizafahmi

@regalius regalius merged commit bb6dba7 into reactjs:master Mar 19, 2019
Copy link
Collaborator

@rizafahmi rizafahmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mendoanjoe @regalius just need 2 small fix, then good to go!

* Ketika sebelumnya di-*render*, `Calculator` telah menentukan bahwa `onTemperatureChange` dari `TemperatureInput` Celcius adalah metode `handleCelsiusChange` milik `Calculator`, dan `onTemperatureChange` dari `TemperatureInput` Fahrenheit adalah metode `handleFahrenheitChange` milik `Calculator`. Jadi salah satu dari dua metode `Calculator` dipanggil tergantung pada masukan yang kita ubah.
* Di dalam metode ini, komponen `Calculator` meminta React untuk mengulang *render* dengan memanggil `this.setState()` dengan nilai masukan baru dan skala masukan saat ini yang baru saja kita ubah.
* React memanggil komponen `Calculator` metode `render` untuk mempelajari seperti apa tampilan antarmuka pengguna. Nilai kedua masukan dihitung berdasarkan suhu saat ini dan skala aktif. Konversi suhu dilakukan di sini.
* React memanggil metode `render` pada komponen `TemperatureInput` individual dengan *props* baru yang ditentukan oleh `Calculator`. Mreka kemduain mempelajari seperti apa tampilan antarmuka pengguna mereka.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: Mreka -> Mereka

* React memanggil komponen `Calculator` metode `render` untuk mempelajari seperti apa tampilan antarmuka pengguna. Nilai kedua masukan dihitung berdasarkan suhu saat ini dan skala aktif. Konversi suhu dilakukan di sini.
* React memanggil metode `render` pada komponen `TemperatureInput` individual dengan *props* baru yang ditentukan oleh `Calculator`. Mreka kemduain mempelajari seperti apa tampilan antarmuka pengguna mereka.
* React memanggil metode `render` pada komponen `BoilingVerdict`, melewati suhu dalam Celcius sebagai *props*.
* React DOM memperbarui dengan vonis didih dan untuk mencocokan nilai masukan yang diinginkan. Masukan yang baru saja kita ubah menerima nilainya saat ini, dan masukan lainnya diperbarui ke suhu setelah konversi.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"React DOM memperbarui dengan vonis didih" -> "React DOM memperbaharui nilai titik didih"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants