Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate hooks-faq #115

Merged
merged 9 commits into from Mar 7, 2019
Merged

Translate hooks-faq #115

merged 9 commits into from Mar 7, 2019

Conversation

smikitky
Copy link
Member

Translation for hooks-faq.md (Hooks FAQ)

Note In the original markdown file, explicit IDs are currently missing after #how-do-i-implement-getderivedstatefromprops. I restored them from the ToC at the beginning of the article.

@smikitky
Copy link
Member Author

PR #118 でIDの修正が入りましたので先にそちらの master マージが必要です

@tesseralis tesseralis mentioned this pull request Feb 13, 2019
90 tasks
@smikitky
Copy link
Member Author

#118 の取り込みが終わったのでデータ的にはいつでもマージ可能です

@netlify
Copy link

netlify bot commented Feb 24, 2019

Deploy preview for ja-reactjs ready!

Built with commit ac49079

https://deploy-preview-115--ja-reactjs.netlify.com

@koba04 koba04 added the 🚫 in intial review 初期レビューの真っ最中 label Feb 26, 2019
Copy link
Member

@koba04 koba04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smikitky 一点だけ言い回しの調整についてコメントしましたがIMOなので、Approveしておきます! 👍

content/docs/hooks-faq.md Outdated Show resolved Hide resolved
Co-Authored-By: smikitky <smiki-tky@umin.ac.jp>
@smikitky smikitky removed the 🚫 in intial review 初期レビューの真っ最中 label Feb 26, 2019
@smikitky
Copy link
Member Author

smikitky commented Mar 5, 2019

@potato4d 時間があれば確認お願いします

@potato4d
Copy link
Member

potato4d commented Mar 7, 2019

これ確認済みです 🙇

Copy link
Member

@potato4d potato4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve 遅れてすみません 🙇
確認済みで、問題ありません!

@potato4d potato4d merged commit ba41004 into master Mar 7, 2019
@potato4d potato4d deleted the tr/hooks-faq branch March 12, 2019 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants