Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translate faq-versioning #121

Merged
merged 6 commits into from Feb 16, 2019
Merged

translate faq-versioning #121

merged 6 commits into from Feb 16, 2019

Conversation

37108
Copy link

@37108 37108 commented Feb 14, 2019

related issue: #4
Translation: Versioning Policy

レビューをお願いいたします 🙇

@smikitky smikitky self-requested a review February 14, 2019 03:39
@smikitky smikitky added the 🚫 in intial review 初期レビューの真っ最中 label Feb 14, 2019
Copy link
Member

@smikitky smikitky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

確認しました。幾つか訳文の修正をお願いしたいところがありますので対応をお願い致します。

content/docs/faq-versioning.md Outdated Show resolved Hide resolved
content/docs/faq-versioning.md Outdated Show resolved Hide resolved
content/docs/faq-versioning.md Outdated Show resolved Hide resolved
content/docs/faq-versioning.md Outdated Show resolved Hide resolved
content/docs/faq-versioning.md Outdated Show resolved Hide resolved
content/docs/faq-versioning.md Outdated Show resolved Hide resolved
content/docs/faq-versioning.md Outdated Show resolved Hide resolved
content/docs/faq-versioning.md Outdated Show resolved Hide resolved
content/docs/faq-versioning.md Outdated Show resolved Hide resolved
content/docs/faq-versioning.md Outdated Show resolved Hide resolved
@smikitky smikitky removed the 🚫 in intial review 初期レビューの真っ最中 label Feb 14, 2019
@37108
Copy link
Author

37108 commented Feb 14, 2019

@smikitky

確認しました。幾つか訳文の修正をお願いしたいところがありますので対応をお願い致します。

承知しました。対応させていただきます。レビューありがとうございます。🙇

@tesseralis tesseralis mentioned this pull request Feb 14, 2019
90 tasks
@37108
Copy link
Author

37108 commented Feb 14, 2019

レビューに沿っての修正と確認を実施しました。

確認をお願いいたします。 🙇

Copy link
Member

@smikitky smikitky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

すみません、この2点について追加でお願いします m(_ _)m

content/docs/faq-versioning.md Outdated Show resolved Hide resolved
content/docs/faq-versioning.md Outdated Show resolved Hide resolved
smikitky and others added 2 commits February 14, 2019 19:45
Co-Authored-By: 37108 <03230@protonmail.com>
Co-Authored-By: 37108 <03230@protonmail.com>
@37108
Copy link
Author

37108 commented Feb 14, 2019

レビューありがとうございます。
2点とも修正しました。

@smikitky
Copy link
Member

ありがとうございました!

Copy link
Member

@potato4d potato4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よさそうですー!

@potato4d potato4d merged commit be36711 into reactjs:master Feb 16, 2019
@potato4d
Copy link
Member

#4 には反映済み

@37108
Copy link
Author

37108 commented Feb 16, 2019

ご対応ありがとうございました!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants