Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate Tutorial #144

Merged
merged 9 commits into from
Mar 1, 2019
Merged

Translate Tutorial #144

merged 9 commits into from
Mar 1, 2019

Conversation

smikitky
Copy link
Member

Translations for the Tutorial page.

WIP: Still not ready for review

@netlify
Copy link

netlify bot commented Feb 23, 2019 •
edited
Loading

Deploy preview for ja-reactjs ready!

Built with commit 511610e

https://deploy-preview-144--ja-reactjs.netlify.com

@smikitky smikitky marked this pull request as ready for review February 24, 2019 06:01
@tesseralis tesseralis mentioned this pull request Feb 25, 2019
Closed
90 tasks
@smikitky smikitky mentioned this pull request Feb 27, 2019
Closed
@koba04 koba04 added the 🚫 in intial review 初期レビューの真っ最中 label Feb 28, 2019
koba04
koba04 approved these changes Feb 28, 2019
View reviewed changes
Copy link
Member

@koba04 koba04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

かなりのボリュームですね、翻訳お疲れ様でした！

細かい点ばかりですがいくつかコメントしたので確認お願いします。
IMOなので、Approveにしています。

content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
@koba04 koba04 removed the 🚫 in intial review 初期レビューの真っ最中 label Feb 28, 2019
koba04 and others added 2 commits March 1, 2019 00:20
@smikitky
Copy link
Member Author

ここまで全部反映させました、大変なレビューをありがとうございました 🙏

potato4d
potato4d approved these changes Mar 1, 2019
View reviewed changes
Copy link
Member

@potato4d potato4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

お疲れ様です！私も確認しました。よさそうです！

@koba04 koba04 merged commit a9e0f4d into master Mar 1, 2019
@koba04
Copy link
Member

koba04 commented Mar 1, 2019

mergeしました！ 👏👏👏

@potato4d potato4d deleted the tr/tutorial branch March 4, 2019 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koba04 koba04 koba04 approved these changes

@potato4d potato4d potato4d approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@smikitky @koba04 @potato4d