Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate two pages and some MDX tags #451

Merged
merged 2 commits into from
Dec 3, 2021
Merged

Translate two pages and some MDX tags #451

merged 2 commits into from
Dec 3, 2021

Conversation

smikitky
Copy link
Member

@smikitky smikitky commented Dec 1, 2021

とりあえずβ版サイトを2ページ翻訳しました。先に数ページ翻訳してから reactjs/react.dev#4135 で頼めばブランチプレビューを（手作業で）セットアップしてくれるそうです。

ローカル環境では cd beta; yarn; yarn dev で正しく表示されています。

  • Gotcha! は「落とし穴」とか「ハマりポイント」とか考えましたがしっくりこなかったので無難に「注意！」にしてみました。
  • イタリック が環境によって表示されない問題は今後改めて修正ということで。
  • prettier は off にしておかないといろいろな問題が出るようです。
  • textlint も動いていませんがその対応は改めて。

@github-actions github-actions bot added the beta label Dec 1, 2021
@smikitky smikitky removed the v2beta label Dec 1, 2021
@koba04 koba04 self-assigned this Dec 1, 2021
@smikitky smikitky mentioned this pull request Dec 1, 2021
Open
koba04
koba04 approved these changes Dec 3, 2021
View reviewed changes
Copy link
Member

@koba04 koba04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!! 👍 👍 👍

@smikitky smikitky merged commit 6776163 into main Dec 3, 2021
@smikitky smikitky deleted the beta-first-translation branch December 3, 2021 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koba04 koba04 koba04 approved these changes

@potato4d potato4d Awaiting requested review from potato4d

Assignees

@koba04 koba04

Labels
beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@smikitky @koba04