Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding-interactivity 翻訳済み #491

Merged
merged 31 commits into from
Apr 13, 2022
Merged

adding-interactivity 翻訳済み #491

merged 31 commits into from
Apr 13, 2022

Conversation

pasteisdenata
Copy link
Contributor

No description provided.

Copy link
Member

@smikitky smikitky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

確認しました。少しでも分かりやすくするために直訳から外れてでも補わせていただいた部分が結構あります(現ドキュメントについても「DeepL 翻訳で見た方がマシ」とか言ってる人すらいるので…)。問題なければ採用してください。

beta/src/pages/learn/adding-interactivity.md Outdated Show resolved Hide resolved
beta/src/pages/learn/adding-interactivity.md Outdated Show resolved Hide resolved
beta/src/pages/learn/adding-interactivity.md Outdated Show resolved Hide resolved
beta/src/pages/learn/adding-interactivity.md Outdated Show resolved Hide resolved
beta/src/pages/learn/adding-interactivity.md Outdated Show resolved Hide resolved
beta/src/pages/learn/adding-interactivity.md Outdated Show resolved Hide resolved
beta/src/pages/learn/adding-interactivity.md Outdated Show resolved Hide resolved
beta/src/pages/learn/adding-interactivity.md Outdated Show resolved Hide resolved
beta/src/pages/learn/adding-interactivity.md Outdated Show resolved Hide resolved
beta/src/pages/learn/adding-interactivity.md Outdated Show resolved Hide resolved
Co-authored-by: Soichiro Miki <smiki-tky@umin.ac.jp>
Co-authored-by: Soichiro Miki <smiki-tky@umin.ac.jp>
Co-authored-by: Soichiro Miki <smiki-tky@umin.ac.jp>
Co-authored-by: Soichiro Miki <smiki-tky@umin.ac.jp>
Co-authored-by: Soichiro Miki <smiki-tky@umin.ac.jp>
Co-authored-by: Soichiro Miki <smiki-tky@umin.ac.jp>
Co-authored-by: Soichiro Miki <smiki-tky@umin.ac.jp>
Co-authored-by: Soichiro Miki <smiki-tky@umin.ac.jp>
Co-authored-by: Soichiro Miki <smiki-tky@umin.ac.jp>
Co-authored-by: Soichiro Miki <smiki-tky@umin.ac.jp>
Co-authored-by: Soichiro Miki <smiki-tky@umin.ac.jp>
Co-authored-by: Soichiro Miki <smiki-tky@umin.ac.jp>
@pasteisdenata
Copy link
Contributor Author

@smikitky 頂いたコメントを反映させていただきました。お時間を取って頂き大変恐縮です。ja.reactjs のスタイル ルールに基づき翻訳クオリティを向上するように努力します。

@smikitky smikitky self-requested a review April 12, 2022 16:13
@github-actions
Copy link

github-actions bot commented Apr 12, 2022

Size Changes

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/learn/adding-interactivity 62.63 KB (🟡 +1.24 KB) 157.83 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link
Member

@smikitky smikitky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございました!

あと次回から suggestion の適用には「バッチコミット」をしていただけると助かります。グレーアウトされていたと思いますが「Files changed (1)」のタブからやれば大丈夫です。

https://qiita.com/YusukeHosonuma/items/99cb430c7723bf991cfa

Copy link
Member

@smikitky smikitky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

すみません、微修正ですが

  • 大文字小文字の表記揺れ統一
  • 「できる」「出来る」の表記揺れ統一
  • その他細かい表記ミスの修正

を行いました。

beta/src/pages/learn/adding-interactivity.md Outdated Show resolved Hide resolved
beta/src/pages/learn/adding-interactivity.md Outdated Show resolved Hide resolved
beta/src/pages/learn/adding-interactivity.md Outdated Show resolved Hide resolved
beta/src/pages/learn/adding-interactivity.md Outdated Show resolved Hide resolved
beta/src/pages/learn/adding-interactivity.md Outdated Show resolved Hide resolved
beta/src/pages/learn/adding-interactivity.md Outdated Show resolved Hide resolved
beta/src/pages/learn/adding-interactivity.md Outdated Show resolved Hide resolved
beta/src/pages/learn/adding-interactivity.md Outdated Show resolved Hide resolved
beta/src/pages/learn/adding-interactivity.md Outdated Show resolved Hide resolved
beta/src/pages/learn/adding-interactivity.md Outdated Show resolved Hide resolved
Co-authored-by: Soichiro Miki <smiki-tky@umin.ac.jp>
Copy link
Member

@koba04 koba04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 翻訳ありがとうございます!

@koba04 koba04 merged commit e68768b into reactjs:main Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants