Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate createContext #638

Merged
merged 7 commits into from
Aug 24, 2023
Merged

Conversation

natsuokawai
Copy link
Contributor

No description provided.

Copy link
Member

@smikitky smikitky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ほとんどは訳語統一やフォーマット関連です。ご確認をお願いします。

src/content/reference/react/createContext.md Outdated Show resolved Hide resolved
src/content/reference/react/createContext.md Outdated Show resolved Hide resolved
src/content/reference/react/createContext.md Outdated Show resolved Hide resolved
src/content/reference/react/createContext.md Outdated Show resolved Hide resolved
src/content/reference/react/createContext.md Outdated Show resolved Hide resolved
src/content/reference/react/createContext.md Outdated Show resolved Hide resolved
src/content/reference/react/createContext.md Outdated Show resolved Hide resolved
src/content/reference/react/createContext.md Outdated Show resolved Hide resolved
src/content/reference/react/createContext.md Outdated Show resolved Hide resolved
src/content/reference/react/createContext.md Outdated Show resolved Hide resolved
Copy link
Member

@smikitky smikitky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

間違って approve してしまったので request changes し直します

@natsuokawai
Copy link
Contributor Author

レビューありがとうございます。スタイルの指摘を多くさせてしまいすみません。

Copy link
Member

@smikitky smikitky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 箇所修正漏れがあるようですので対応をお願いします。

src/content/reference/react/createContext.md Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Jul 20, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@smikitky
Copy link
Member

すみません、リンクが複数箇所外れているのに気付いたので修正させていただきました。

Copy link
Member

@koba04 koba04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 ありがとうございます!!

@koba04 koba04 merged commit ea6fb5c into reactjs:main Aug 24, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants