Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate "Using TypeScript" #659

Merged
merged 4 commits into from
Sep 5, 2023
Merged

Translate "Using TypeScript" #659

merged 4 commits into from
Sep 5, 2023

Conversation

smikitky
Copy link
Member

No description provided.

@github-actions
Copy link

github-actions bot commented Aug 22, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 79.17 KB (🟡 +4 B) 183.13 KB
/500 79.16 KB (🟡 +4 B) 183.13 KB
/[[...markdownPath]] 80.83 KB (🟡 +4 B) 184.79 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@@ -339,7 +339,7 @@ const visibleTodos = useMemo(() => filterTodos(todos, tab), [todos, tab]);

### `useCallback` {/*typing-usecallback*/}

The [`useCallback`](/reference/react/useCallback) provide a stable reference to a function as long as the dependencies passed into the second parameter are the same. Like `useMemo`, the function's type is inferred from the return value of the function in the first parameter, and you can be more explicit by providing a type argument to the hook.
[`useCallback`](/reference/react/useCallback) は、第 2 引数に渡される依存配列が同じである限り、関数への安定した参照を提供するものです。`useMemo` と同様に、関数の型は 1 番目の引数として指定した関数から推論され、フックに型引数を指定することでより明示的にすることができます。
Copy link
Member Author

@smikitky smikitky Aug 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"inferred from the return value of the function" の部分は意図的に「関数から推論され」としてありますが大丈夫でしょうか。渡した関数は返り値だけでなく引数側も型推論に使用されるはずなので。

Copy link
Member

@koba04 koba04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 一点だけコメントしましたが、レビューとしては Approve しておきます。

src/content/learn/typescript.md Outdated Show resolved Hide resolved
Co-authored-by: Toru Kobayashi <koba0004@gmail.com>
@smikitky smikitky merged commit 8b475f3 into main Sep 5, 2023
2 of 4 checks passed
@smikitky smikitky deleted the tr/typescript branch September 5, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants