Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Replace reactjs.org to ja.reactjs.org in configuration files #8

Merged
merged 4 commits into from Feb 16, 2019
Merged

chore: Replace reactjs.org to ja.reactjs.org in configuration files #8

merged 4 commits into from Feb 16, 2019

Conversation

potato4d
Copy link
Member

@potato4d potato4d commented Feb 1, 2019 •
edited

This PR is resolve #7

ToDos

@gaearon
Copy link
Member

gaearon commented Feb 1, 2019

@tesseralis We'll want a PR like this to be part of "setting up a fork" instructions

@koba04
Copy link
Member

koba04 commented Feb 1, 2019

#1 has been resolved, so we use ja as our subdomain.
What license should we take? Is it better to keep the same license with reactjs.org?

@gaearon
Copy link
Member

gaearon commented Feb 1, 2019

The license should be the same.

@potato4d potato4d changed the title WIP: chore: Replace reactjs.org to ja.reactjs.org in configuration files chore: Replace reactjs.org to ja.reactjs.org in configuration files Feb 2, 2019
@potato4d
Copy link
Member Author

potato4d commented Feb 2, 2019

Thank you for your reply.
Even for quick follow up, we will keep the license as a link to the origin docs.
https://github.com/reactjs/ja.reactjs.org/blob/master/README.md#license

@gaearon
that's fine?

@potato4d potato4d requested a review from gaearon February 2, 2019 02:36
@smikitky smikitky self-requested a review February 7, 2019 12:45
@tesseralis
Copy link
Member

There's also changing it to lang="ja" in html.js, though I don't know if you want that in a separate PR.

@potato4d
Copy link
Member Author

@tesseralis
I have done it now.

@koba04
Please review 🙏

@potato4d
Copy link
Member Author

ちょっと rebase するのでお待ちを 🙇

@potato4d
Copy link
Member Author

@koba04
みてもらえるとー

koba04
koba04 approved these changes Feb 15, 2019
View reviewed changes
Copy link
Member

@koba04 koba04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@potato4d potato4d merged commit bc347b1 into master Feb 16, 2019
@potato4d potato4d deleted the chore/update-domain-settings branch February 20, 2019 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koba04 koba04 koba04 approved these changes

@smikitky smikitky smikitky approved these changes

@gaearon gaearon Awaiting requested review from gaearon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update domain settings in package.json and JavaScript code base
5 participants
@potato4d @gaearon @koba04 @tesseralis @smikitky