Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate reference-glossary #16

Merged
merged 9 commits into from Mar 3, 2019
Merged

Translate reference-glossary #16

merged 9 commits into from Mar 3, 2019

Conversation

gnujoow
Copy link
Member

@gnujoow gnujoow commented Feb 10, 2019 •
edited

#2

here is PR for reference-glossary. It would be nice to have a discussion on how to translate terms and translate style in the process of merging this PR. Once we have some feedback, I will create glossary and style guide like following links to help other contributors to translate documentation.

here is the rule I followed

- 문서의 내용이 친근하게 다가올 수 있도록 경어체를 사용하여 번역합니다.
- 고유명사는 원문 그대로 사용합니다. (예, React, Facebook)
- 기술용어 / 합성어는 최대한 번역하되 의미가 와닿지 않는 경우에는 음역으로 표시합니다.
(예, lifecycle method -> 생명주기 함수 / Component -> 컴포넌트 )

progress

  • translation draft
  • check PR review
  • Submit final

gnujoow
gnujoow commented Feb 10, 2019
View reviewed changes
Copy link
Member Author

@gnujoow gnujoow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

번역을 진행하면서 어색하다고 생각하는 부분들을 코멘트로 달아두었습니다. 리뷰하실때 참고해주시면 감사하겠습니다. :)

content/docs/reference-glossary.md Outdated Show resolved Hide resolved
content/docs/reference-glossary.md Outdated Show resolved Hide resolved
content/docs/reference-glossary.md Show resolved Hide resolved
content/docs/reference-glossary.md Outdated Show resolved Hide resolved
content/docs/reference-glossary.md Outdated Show resolved Hide resolved
content/docs/reference-glossary.md Outdated Show resolved Hide resolved
content/docs/reference-glossary.md Outdated Show resolved Hide resolved
content/docs/reference-glossary.md Outdated Show resolved Hide resolved
content/docs/reference-glossary.md Outdated Show resolved Hide resolved
content/docs/reference-glossary.md Outdated Show resolved Hide resolved
@tesseralis tesseralis mentioned this pull request Feb 10, 2019
Closed
98 tasks
@gnujoow gnujoow added discussion Discuss the problem. and removed discussion Discuss the problem. labels Feb 10, 2019
taggon
taggon reviewed Feb 10, 2019
View reviewed changes
content/docs/reference-glossary.md Outdated Show resolved Hide resolved
content/docs/reference-glossary.md Outdated Show resolved Hide resolved
content/docs/reference-glossary.md Outdated Show resolved Hide resolved
content/docs/reference-glossary.md Outdated Show resolved Hide resolved
content/docs/reference-glossary.md Outdated Show resolved Hide resolved
content/docs/reference-glossary.md Outdated Show resolved Hide resolved
content/docs/reference-glossary.md Outdated Show resolved Hide resolved
content/docs/reference-glossary.md Outdated Show resolved Hide resolved
content/docs/reference-glossary.md Outdated Show resolved Hide resolved
content/docs/reference-glossary.md Outdated Show resolved Hide resolved
@ENvironmentSet ENvironmentSet mentioned this pull request Feb 11, 2019
Merged
@taehwanno taehwanno mentioned this pull request Feb 11, 2019
Closed
@gnujoow
Copy link
Member Author

gnujoow commented Feb 12, 2019 •
edited

오늘 중으로 리뷰사항을 푸시하겠습니다. 리뷰해주신 여러분들 감사합니다 👍

taggon
taggon reviewed Feb 12, 2019
View reviewed changes
content/docs/reference-glossary.md Outdated Show resolved Hide resolved
content/docs/reference-glossary.md Outdated Show resolved Hide resolved
content/docs/reference-glossary.md Outdated Show resolved Hide resolved
content/docs/reference-glossary.md Outdated Show resolved Hide resolved
content/docs/reference-glossary.md Outdated Show resolved Hide resolved
content/docs/reference-glossary.md Outdated Show resolved Hide resolved
content/docs/reference-glossary.md Outdated Show resolved Hide resolved
content/docs/reference-glossary.md Show resolved Hide resolved
content/docs/reference-glossary.md Outdated Show resolved Hide resolved
content/docs/reference-glossary.md Outdated Show resolved Hide resolved
gnujoow
gnujoow commented Feb 13, 2019
View reviewed changes
Copy link
Member Author

@gnujoow gnujoow left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

최종 PR은 15일까지 올리도록 하겠습니다.

@gnujoow
resolve reivew for reference-glossary #2
a3d1f46
@gnujoow
glossary 적용
efcb2ae 
제어 컴포넌트, 비제어 컴포넌트 용어에 맞게 적용함
@gnujoow
Copy link
Member Author

gnujoow commented Feb 21, 2019

리뷰 사항 모두 반영하였습니다. 리뷰 진행해주시면 감사하겠습니다 ;)

simsim0709
simsim0709 reviewed Feb 22, 2019
View reviewed changes
content/docs/reference-glossary.md

React elements are the building blocks of React applications. One might confuse elements with a more widely known concept of "components". An element describes what you want to see on the screen. React elements are immutable.
React 엘리먼트(React Element)는 React 애플리캐이션을 구성하는 블록입니다. 엘리먼트는 "컴포넌트(Component)"라는 널리 알려진 개념과 혼동되기 쉽습니다. 엘리먼트는 화면에 보이는 것들을 기술하며, React 엘리먼트는 변경되지 않습니다.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"React elements are immutable"에서 immutable이 immutable data(불변 데이터)를 나타내는 건지 "변경되지 않는"이 맞는지 헷갈리네요.. 😓

Copy link
Member Author

@gnujoow gnujoow Feb 24, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

문장 다음에 나오는 예제로 봐서는 element가 immutable이라고 설명하는 것 같아서 위와 같이 번역했어요. 불변이라고 하면 어색한 표현인 것 같아 "변경되지 않는"으로 번역하였습니다. :) @simsim0709

@taehwanno
Copy link
Member

upstream과 sync되면서 master 브랜치의 모든 링크 주소가 https로 변경되어 직접 충돌 해결했습니다.

@netlify
Copy link

netlify bot commented Feb 23, 2019 •
edited

Deploy preview for ko-reactjs-org ready!

Built with commit 9d9b297

https://deploy-preview-16--ko-reactjs-org.netlify.com

hg-pyun
hg-pyun previously approved these changes Feb 25, 2019
View reviewed changes
Copy link
Member

@hg-pyun hg-pyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

taehwanno
taehwanno reviewed Feb 25, 2019
View reviewed changes
content/docs/reference-glossary.md Outdated Show resolved Hide resolved
content/docs/reference-glossary.md Outdated Show resolved Hide resolved
content/docs/reference-glossary.md Outdated Show resolved Hide resolved
@taehwanno taehwanno mentioned this pull request Feb 25, 2019
Merged
@taehwanno
Copy link
Member

resolve 되지 않은 코멘트 3개 정리되면 바로 반영하도록 할게요 :)

@taehwanno taehwanno added the needs author response Changes requested needing author's input label Feb 28, 2019
@gnujoow
Copy link
Member Author

gnujoow commented Mar 3, 2019

resolve 되지 않은 코멘트 3개 정리되면 바로 반영하도록 할게요 :)

모두 반영하였습니다.

@gnujoow gnujoow removed the needs author response Changes requested needing author's input label Mar 3, 2019
@taehwanno taehwanno merged commit c71fce2 into reactjs:master Mar 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taggon taggon taggon left review comments

@simsim0709 simsim0709 simsim0709 left review comments

@noahluftyang noahluftyang noahluftyang left review comments

@hewonjeong hewonjeong hewonjeong left review comments

@ENvironmentSet ENvironmentSet ENvironmentSet left review comments

@taehwanno taehwanno taehwanno approved these changes

@hg-pyun hg-pyun hg-pyun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@gnujoow @taehwanno @taggon @simsim0709 @hg-pyun @noahluftyang @hewonjeong @ENvironmentSet