Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate Fragments #13

Merged
merged 2 commits into from Feb 11, 2019
Merged

Translate Fragments #13

merged 2 commits into from Feb 11, 2019

Conversation

gustavoaz7
Copy link
Contributor

#1

glaucia86
glaucia86 reviewed Feb 8, 2019
View reviewed changes
content/docs/fragments.md Outdated Show resolved Hide resolved
glaucia86
glaucia86 reviewed Feb 8, 2019
View reviewed changes
content/docs/fragments.md Outdated Show resolved Hide resolved
glaucia86
glaucia86 reviewed Feb 8, 2019
View reviewed changes
content/docs/fragments.md Outdated Show resolved Hide resolved
glaucia86
glaucia86 reviewed Feb 8, 2019
View reviewed changes
content/docs/fragments.md Outdated Show resolved Hide resolved
glaucia86
glaucia86 reviewed Feb 8, 2019
View reviewed changes
content/docs/fragments.md Outdated Show resolved Hide resolved
glaucia86
glaucia86 reviewed Feb 8, 2019
View reviewed changes
content/docs/fragments.md Outdated Show resolved Hide resolved
glaucia86
glaucia86 reviewed Feb 8, 2019
View reviewed changes
content/docs/fragments.md Outdated Show resolved Hide resolved
glaucia86
glaucia86 reviewed Feb 8, 2019
View reviewed changes
content/docs/fragments.md Outdated Show resolved Hide resolved
glaucia86
glaucia86 requested changes Feb 8, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gustavoaz7 pequenas alterações a serem realizadas.
Assim que concluir as alterações de cada item sinalizado, peço que marque como 'Resolve Conversation'

E me sinalize para que eu possa dar uma olhada de novo e enfim aprovar a sua contribuição. Muito obrigada.

@glaucia86 glaucia86 added the needs review A pull request ready to be reviewed label Feb 8, 2019
@cezaraugusto cezaraugusto added needs author response Changes requested needing author's input and removed needs review A pull request ready to be reviewed labels Feb 8, 2019
@glaucia86
Copy link
Member

@gustavoaz7

assim que você concluir as suas mudanças, marque como 'Resolve Conversation' e altere para a label: 'changes already resolved it - translator'.
Muito obrigada pela sua contribuição! 😄

@gustavoaz7
Copy link
Contributor Author

@glaucia86
Código alterado de acordo com comentários :)

WendellAdriel
WendellAdriel approved these changes Feb 11, 2019
View reviewed changes
Copy link
Member

@WendellAdriel WendellAdriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!! 😉

@WendellAdriel WendellAdriel added needs +1 Needs another approval before merging feedback addressed and removed needs author response Changes requested needing author's input labels Feb 11, 2019
glaucia86
glaucia86 approved these changes Feb 11, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gustavoaz7

LGTM 👍
Queremos agradecer pela sua excelente contribuição! Muito obrigada!

@glaucia86 glaucia86 merged commit c4be73a into reactjs:master Feb 11, 2019
@glaucia86 glaucia86 added 🌐 translated Translation is completed for this page and removed feedback addressed needs +1 Needs another approval before merging labels Feb 11, 2019
@tesseralis tesseralis mentioned this pull request Feb 11, 2019
Closed
90 tasks
@gustavoaz7 gustavoaz7 deleted the translate-fragments branch February 11, 2019 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glaucia86 glaucia86 glaucia86 approved these changes

@WendellAdriel WendellAdriel WendellAdriel approved these changes

Assignees
No one assigned
Labels
🌐 translated Translation is completed for this page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gustavoaz7 @glaucia86 @WendellAdriel @cezaraugusto