Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The one with hooks #162

Merged
merged 51 commits into from Mar 15, 2019
Merged

The one with hooks #162

merged 51 commits into from Mar 15, 2019

Conversation

0xc41qu3
Copy link

No description provided.

@0xc41qu3 0xc41qu3 mentioned this pull request Mar 12, 2019
45 tasks
@netlify
Copy link

netlify bot commented Mar 12, 2019

Deploy preview for pt-br-reactjs ready!

Built with commit 0f274aa

https://deploy-preview-162--pt-br-reactjs.netlify.com

@jhonmike jhonmike added the needs review A pull request ready to be reviewed label Mar 12, 2019
@0xc41qu3
Copy link
Author

Hey guys! Where could I find the date of the article to translate it?
Example: "February 06, 2019 by Dan Abramov".

@jhonmike jhonmike added the blog Blog post translation label Mar 12, 2019
@jlucfarias
Copy link

I think it's not translatable because, as you can see here and here, this information come from the database.

@halian-vilela
Copy link
Collaborator

@CaiqueMOliveira @John-Luke

Pessoal, podem falar português nas discussões ok?

Eu vou checar com o pessoal do React Core se há alguma maneira melhor de traduzir a data.

@0xc41qu3
Copy link
Author

I think it's not translatable because, as you can see here and here, this information come from the database.

Ah sim! Obrigado @John-Luke ;)

@halian-vilela
Copy link
Collaborator

I think it's not translatable because, as you can see here and here, this information come from the database.

Ah sim! Obrigado @John-Luke ;)

O "by" dá pra traduzir com "por" aqui: https://github.com/reactjs/pt-BR.reactjs.org/blob/0e57e84754fa9711edb042ecc273c1c3281e70a3/src/components/MarkdownPage/MarkdownPage.js#L91

Eu to vendo com o pessoal do core se a gente consegue mudar o locale e o formato da data na query que é feita no outro arquivo.

Assim que obtiver uma resposta eu aviso vocês.

@jlucfarias
Copy link

jlucfarias commented Mar 12, 2019

Eu achei esse link que pode ajudar

No caso, só precisaria alterar a ordem do formato da data e adicionar o argumento locale: 'pt-br'

@halian-vilela
Copy link
Collaborator

halian-vilela commented Mar 12, 2019

Eu achei esse link que pode ajudar

@John-Luke @CaiqueMOliveira

Fantástico, eu acho que isso solucionaria, temos que testar.

Mas de qualquer maneira o ideal é manter esse arquivo de tradução em separado desses ajustes. Se vcs quiserem (e puderem) ver isso agora, sugiro abrir uma PR separada pra tratar só disso e fazer as mundanças específicas nos 2 arquivos.

Caso não puderem agora, de noite eu dou uma olhada.

Tenho que voltar pro trampo aqui.

Abs!

@jlucfarias
Copy link

Eu vou ter a tarde livre, então pode deixar que eu faço os ajustes nisso

Copy link
Contributor

@felipemfp felipemfp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Em geral, o que notei foi a utilização de "React Hooks" como algo singular, enquanto que a documentação original/oficial utiliza como uma coleção, ou seja, no plural.

content/blog/2019-02-06-react-v16.8.0.md Outdated Show resolved Hide resolved
content/blog/2019-02-06-react-v16.8.0.md Outdated Show resolved Hide resolved
content/blog/2019-02-06-react-v16.8.0.md Outdated Show resolved Hide resolved
content/blog/2019-02-06-react-v16.8.0.md Outdated Show resolved Hide resolved
content/blog/2019-02-06-react-v16.8.0.md Outdated Show resolved Hide resolved
content/blog/2019-02-06-react-v16.8.0.md Outdated Show resolved Hide resolved
content/blog/2019-02-06-react-v16.8.0.md Outdated Show resolved Hide resolved
content/blog/2019-02-06-react-v16.8.0.md Outdated Show resolved Hide resolved
content/blog/2019-02-06-react-v16.8.0.md Outdated Show resolved Hide resolved
content/blog/2019-02-06-react-v16.8.0.md Outdated Show resolved Hide resolved
felipemfp and others added 10 commits March 13, 2019 00:12
Co-Authored-By: CaiqueMOliveira <caique.m.oliveira.br@gmail.com>
Co-Authored-By: CaiqueMOliveira <caique.m.oliveira.br@gmail.com>
Co-Authored-By: CaiqueMOliveira <caique.m.oliveira.br@gmail.com>
Co-Authored-By: CaiqueMOliveira <caique.m.oliveira.br@gmail.com>
Co-Authored-By: CaiqueMOliveira <caique.m.oliveira.br@gmail.com>
Co-Authored-By: CaiqueMOliveira <caique.m.oliveira.br@gmail.com>
Co-Authored-By: CaiqueMOliveira <caique.m.oliveira.br@gmail.com>
Co-Authored-By: CaiqueMOliveira <caique.m.oliveira.br@gmail.com>
Bem observado, obrigado.

Co-Authored-By: CaiqueMOliveira <caique.m.oliveira.br@gmail.com>
Co-Authored-By: CaiqueMOliveira <caique.m.oliveira.br@gmail.com>
@0xc41qu3
Copy link
Author

Em geral, o que notei foi a utilização de "React Hooks" como algo singular, enquanto que a documentação original/oficial utiliza como uma coleção, ou seja, no plural.

@felipemfp de fato não me atentei a estes aspectos. Falha minha :(
Mas agradeço por todas as sugestões, inclusive grande parte delas foram aceitas... caso encontre mais alguma, por favor, não deixe de mandar. Muito obrigado !! 👍

@jlucfarias jlucfarias mentioned this pull request Mar 13, 2019
Caique M. Oliveira and others added 2 commits March 13, 2019 14:52
Co-Authored-By: CaiqueMOliveira <caique.m.oliveira.br@gmail.com>
Copy link
Author

@0xc41qu3 0xc41qu3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Após realizar grande parte das mudanças, acredito que esta versão já pode ser validada.

content/blog/2019-02-06-react-v16.8.0.md Outdated Show resolved Hide resolved
content/blog/2019-02-06-react-v16.8.0.md Outdated Show resolved Hide resolved
content/blog/2019-02-06-react-v16.8.0.md Outdated Show resolved Hide resolved
content/blog/2019-02-06-react-v16.8.0.md Outdated Show resolved Hide resolved
content/blog/2019-02-06-react-v16.8.0.md Outdated Show resolved Hide resolved
@jhonmike jhonmike added needs author response Changes requested needing author's input and removed needs review A pull request ready to be reviewed labels Mar 14, 2019
Jhon Mike and others added 5 commits March 14, 2019 15:45
Co-Authored-By: CaiqueMOliveira <caique.m.oliveira.br@gmail.com>
Co-Authored-By: CaiqueMOliveira <caique.m.oliveira.br@gmail.com>
Co-Authored-By: CaiqueMOliveira <caique.m.oliveira.br@gmail.com>
Vacilo meu. Vlw

Co-Authored-By: CaiqueMOliveira <caique.m.oliveira.br@gmail.com>
jhonmike
jhonmike previously approved these changes Mar 14, 2019
Co-Authored-By: CaiqueMOliveira <caique.m.oliveira.br@gmail.com>
@jhonmike jhonmike merged commit ffcabd4 into reactjs:master Mar 15, 2019
@jhonmike jhonmike added 🌐 translated Translation is completed for this page and removed needs author response Changes requested needing author's input labels Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blog Blog post translation 🌐 translated Translation is completed for this page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants