Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Special props translation #28

Merged
merged 8 commits into from Feb 9, 2019
Merged

Special props translation #28

merged 8 commits into from Feb 9, 2019

Conversation

andrescalco
Copy link
Contributor

#1

glaucia86
glaucia86 requested changes Feb 9, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrescalco pequenas alterações a serem feitas. Altere agora que já aprovo esse PR. ;)

content/warnings/special-props.md Outdated Show resolved Hide resolved
content/warnings/special-props.md Outdated Show resolved Hide resolved
@glaucia86 glaucia86 added the needs review A pull request ready to be reviewed label Feb 9, 2019
@glaucia86 @andrescalco
Update content/warnings/special-props.md
333a875 
Co-Authored-By: andrescalco <andre@andrescalco.com>
glaucia86
glaucia86 previously approved these changes Feb 9, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

cc: @cezaraugusto @WendellAdriel it's a short translation. Can we approve this PR?

@glaucia86 glaucia86 added the needs +1 Needs another approval before merging label Feb 9, 2019
@andrescalco
Copy link
Contributor Author

Prontinho! Amanhã acho que consigo pegar mais alguns dos warnings e traduzí-los XD

eduardomoroni
eduardomoroni previously requested changes Feb 9, 2019
View reviewed changes
Copy link
Member

@eduardomoroni eduardomoroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Algumas sugestões @andrescalco, caso não ache relevante me da o toque que a gente mergeia. :)

content/warnings/special-props.md Outdated Show resolved Hide resolved
content/warnings/special-props.md Outdated Show resolved Hide resolved
@eduardomoroni eduardomoroni added needs author response Changes requested needing author's input and removed needs +1 Needs another approval before merging needs review A pull request ready to be reviewed labels Feb 9, 2019
@andrescalco
Copy link
Contributor Author

@eduardomoroni as sugestões fazem sentido sim! Vou alterar e fazer o commit.

@glaucia86 seria interessante lá na #1 fazer o assign dessa tradução para mim,não acha?

@andrescalco
Copy link
Contributor Author

Meu último commit não tinha as alterções da @glaucia86. Agora está tudo certo XD

fjoshuajr
fjoshuajr requested changes Feb 9, 2019
View reviewed changes
Copy link
Collaborator

@fjoshuajr fjoshuajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Veja estas sugestões por favor.

content/warnings/special-props.md Outdated Show resolved Hide resolved
@fjoshuajr @andrescalco
Update content/warnings/special-props.md
da38a48 
Co-Authored-By: andrescalco <andre@andrescalco.com>
cezaraugusto
cezaraugusto approved these changes Feb 9, 2019
View reviewed changes
Copy link
Member

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cezaraugusto cezaraugusto added needs +1 Needs another approval before merging and removed needs author response Changes requested needing author's input labels Feb 9, 2019
@fjoshuajr fjoshuajr dismissed eduardomoroni’s stale review February 9, 2019 21:46

Feedback addressed 👌

@fjoshuajr fjoshuajr merged commit e8b79aa into reactjs:master Feb 9, 2019
@fjoshuajr fjoshuajr added 🌐 translated Translation is completed for this page and removed needs +1 Needs another approval before merging labels Feb 9, 2019
@tesseralis tesseralis mentioned this pull request Feb 9, 2019
Closed
90 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cezaraugusto cezaraugusto cezaraugusto approved these changes

@fjoshuajr fjoshuajr fjoshuajr approved these changes

@eduardomoroni eduardomoroni eduardomoroni left review comments

@glaucia86 glaucia86 glaucia86 left review comments

Assignees
No one assigned
Labels
🌐 translated Translation is completed for this page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@andrescalco @eduardomoroni @glaucia86 @cezaraugusto @fjoshuajr