New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate introducing jsx #47
Merged
glaucia86
merged 8 commits into
reactjs:master
from
ericp3reira:translate-introducing-jsx
Feb 10, 2019
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
110bde1
[Translate: introducing JSX] First block
ericp3reira 38d4431
[Translate: introducing JSX] Why JSX
ericp3reira c855af3
[Translate: introducing JSX] Embedding Expressions in JSX
ericp3reira a811623
[Translate: introducing JSX] JSX is an Expression Too and Specifying …
ericp3reira 97f2dfb
[Translate: introducing JSX] Everything else
ericp3reira 9ead736
[Translate: introducing JSX] Some suggestions
ericp3reira 6990f4b
[Translate: introducing JSX] More suggestions
ericp3reira 3ce1e98
[Translate: introducing JSX] Add other suggestions
ericp3reira File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@glaucia86 Acredito que "contain both" aqui tem o sentido de "conter markup e lógica", certo? Acho que "em ambos" não encaixa, já que são os componentes que contém os dois.
Talvez alterar para "contém tanto o markup quanto a lógica"?