Add Destructure Named Imports Option for update-react-imports
#278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
threepointone
approved these changes
Oct 9, 2020
gaearon
reviewed
Oct 20, 2020
| @@ -147,6 +147,10 @@ npx react-codemod sort-comp <path> | |||
|
|
|||
| [As of Babel 7.9.0](https://babeljs.io/blog/2020/03/16/7.9.0#a-new-jsx-transform-11154-https-githubcom-babel-babel-pull-11154), when using `runtime: automatic` in `@babel/preset-react` or `@babel/plugin-transform-react-jsx`, you will not need to explicitly import React for compiling jsx. This codemod removes the redundant import statements. It also converts (`import React from 'react'`) to named imports (`import * as React from 'react'`). | |||
|
|
|||
| The wizard will ask for 1 option - | |||
|
|
|||
| * **Destructure named imports?**: Destructures named imports (import * as React from 'react') as well as default imports. Does not do this by default. | |||
There was a problem hiding this comment.
Nit: These are "namespace imports", not "named imports". Named imports are what destructuring converts them to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We originally did not destructure named imports because it was pointed out to us that some people might want to keep the
import * as React from 'react'option. However, this issue points out that there are codebases that would prefer to use destructured named imports (ex.import {useState} from 'react') instead now that React no longer needs to be in scope to use JSX. This PR introduces an option to the transform that allows people to choose to destructure named imports as well as default imports.