Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added onclick=> onClick to ATTRIBUTE_MAPPING #150

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nvh95
Copy link

@nvh95 nvh95 commented Nov 22, 2017

Added onclick=> onClick to ATTRIBUTE_MAPPING. Because when transform onclick from HTML to Javascript React it will be onClick (refer to this link https://reactjs.org/docs/handling-events.html)
screen shot 2017-11-22 at 10 13 31 am

@DanBuild
Copy link

Deploy preview ready!

Built with commit 1d52e8f

https://deploy-preview-150--react-magic.netlify.com

@Daniel15
Copy link
Member

Will this actually work properly? Won't it transform onclick="doFoo()" to onClick="doFoo" rather than onClick={doFoo}?

@guitarneck
Copy link

Much more to add in ATTRIBUTE_MAPPING => React SyntheticEvent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants