We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The onAfterClose prop is called when unmounting the ReactModal even if the modal is not opened while the unmount occurs.
onAfterClose
ReactModal
Given the name of the prop, I would have expected the callback prop to be called only when the modal went from opened state to closed state.
https://codesandbox.io/s/54xl6lz32n
The text was updated successfully, but these errors were encountered:
👋 Friendly ping for someone to take a look at the PR 🙏
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
Summary:
The
onAfterClose
prop is called when unmounting the ReactModal even if the modal is not opened while the unmount occurs.Steps to reproduce:
ReactModal
with anonAfterClose
callback.onAfterClose
prop being called each time the ReactModal unmounts.Expected behavior:
Given the name of the prop, I would have expected the callback prop to be called only when the modal went from opened state to closed state.
Link to example of issue:
https://codesandbox.io/s/54xl6lz32n
Additional notes:
The text was updated successfully, but these errors were encountered: