Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fixed] onAfterClose prop called when unmounting a closed modal #755

Merged

Conversation

gados3
Copy link
Contributor

@gados3 gados3 commented May 28, 2019

Fixes #745

Changes proposed:

  • onAfterClose prop will no longer be triggered when unmounting a closed modal, but will still be when unmounting an opened modal.
  • Added .vscode folder to .gitignore

Upgrade Path (for changed or removed APIs): N/A

Acceptance Checklist:

  • The commit message follows the guidelines in CONTRIBUTING.md.
  • Documentation (README.md) and examples have been updated as needed.
  • If this is a code change, a spec testing the functionality has been added.
  • If the commit message has [changed] or [removed], there is an upgrade path above.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 86.652% when pulling 0d970b2 on gados3:fix/745/onAfterClose-called-on-unmount into 6ff8d85 on reactjs:master.

@diasbruno diasbruno merged commit 8a71f71 into reactjs:master Aug 21, 2019
@diasbruno
Copy link
Collaborator

diasbruno commented Aug 21, 2019

@gados3 Thanks for the "ping" and sorry for forgetting this PR.

@diasbruno
Copy link
Collaborator

I'll release a new version soon (ping me again if i forget).

@diasbruno
Copy link
Collaborator

Thanks, @gados3. Released version 3.10.1.

@gdostie
Copy link

gdostie commented Aug 22, 2019

Awesome, thank you @diasbruno.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

onAfterClose prop called on unmount even if modal is closed
4 participants