Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use React Hooks in README #784

Closed
nagayev opened this issue Nov 3, 2019 · 5 comments · Fixed by #783
Closed

Use React Hooks in README #784

nagayev opened this issue Nov 3, 2019 · 5 comments · Fixed by #783

Comments

@nagayev
Copy link
Contributor

nagayev commented Nov 3, 2019

Summary:

React Hooks in modern way to create a React components and maybe soon classes components will be deprecated.

@nagayev
Copy link
Contributor Author

nagayev commented Nov 9, 2019

Can anyone say is it good idea?

@diasbruno
Copy link
Collaborator

Hi @nagayev, it looks good. Not sure if we should keep both or add them to the documentation. What do you think?

@nagayev
Copy link
Contributor Author

nagayev commented Nov 10, 2019

@diasbruno I think classes will deprecate in future, so I think we can use Hooks everyware and delete old docs.

@diasbruno
Copy link
Collaborator

diasbruno commented Nov 10, 2019

Hmm...I'm not sure on this one, it would be great to be on the latest version of react, but this transition will take some time, and I don't how the adoption of hooks going...

Would you mind if we let this open so we can get more input on this? If we get more 👍, it will be a sign that we can move forward on using hooks.

@nagayev
Copy link
Contributor Author

nagayev commented Nov 11, 2019

@diasbruno okey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants