Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README (example with React Hooks) #783

Merged
merged 3 commits into from
Nov 18, 2019
Merged

Update README (example with React Hooks) #783

merged 3 commits into from
Nov 18, 2019

Conversation

nagayev
Copy link
Contributor

@nagayev nagayev commented Nov 3, 2019 •
edited

Fixes #784 .

Changes proposed:

  • Add hook component
  • Delete class component

Acceptance Checklist:

  • The commit message follows the guidelines in CONTRIBUTING.md.
  • Documentation (README.md) and examples have been updated as needed.
  • If this is a code change, a spec testing the functionality has been added.
  • If the commit message has [changed] or [removed], there is an upgrade path above.

diasbruno
diasbruno reviewed Nov 15, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
diasbruno
diasbruno reviewed Nov 15, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Nov 17, 2019 •
edited

Coverage Status

Coverage decreased (-0.3%) to 86.353% when pulling 9cc1920 on nagayev:master into 684d3b8 on reactjs:master.

@nagayev
Copy link
Contributor Author

nagayev commented Nov 17, 2019

@diasbruno
Well, i fixed it.
Is it time to squash and push commits?

@diasbruno
Copy link
Collaborator

Awesome, @nagayev. I'll merge this on Monday. Thanks.

@diasbruno
Copy link
Collaborator

Just make sure that this branch is rebased with master...so we can squash on merge.

@diasbruno diasbruno self-requested a review November 18, 2019 12:51
@diasbruno diasbruno merged commit 98dd5be into reactjs:master Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diasbruno diasbruno diasbruno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use React Hooks in README
3 participants
@nagayev @coveralls @diasbruno