[changed] Don't render div on dom when isOpen is false

[CompuIves]

I noticed that when I wanted to animate the fadein of a modal it only worked for the first time. This was because the css animation of ReactModal__Overlay--after-open only works when a div is rendered for the first time. That's why I changed the logic to render nothing if there is no modal.
I'm aware that this can break a lot of things (like using a ref for ReactModal) for other people, so maybe we need to bump a major version if we want to have this.

Changes proposed:

• When not open, render null instead of div

Upgrade Path (for changed or removed APIs):
When you want to use a ref on ReactModal and use it after it's rendered, you will have to place the call to the ref in a setTimeout so it's accessible after it's rendered.

Acceptance Checklist:

• All commits have been squashed to one.
• The commit message follows the guidelines in CONTRIBUTING.md.
• Documentation (README.md) and examples have been updated as needed.
• If this is a code change, a spec testing the functionality has been added.
• If the commit message has [changed] or [removed], there is an upgrade path above.

This allows users to add an animation for opening the modal.

[diasbruno]

@claydiffrient any thoughts? looks good.

[claydiffrient]

@CompuIves Sorry for the delay on this. Could you change the commit message from [fixed] to [changed] ? I think that will make it easier to indicate that it's more of a breaking change vs. a simple bug fix. I believe this is a valuable change. I'd like to get it in for v2.

[CompuIves]

No problem! I changed it.

[diasbruno]

Hi @CompuIves, we have released v2.0.0. This will need a rebase.

[CompuIves]

Okay! Will do it today.

[CompuIves]

There were a lot of changes, I decided to just recreate the changes based on new master.

I wasn't able to reproduce the rendering of div instead of null in the tests anymore, maybe I'm doing something wrong or something has changed.

[coveralls]

Coverage decreased (-13.5%) to 71.429% when pulling dc14e2d on CompuIves:master into 8f3898a on reactjs:master.

[diasbruno]

Awesome, @CompuIves!
Perhaps after close the modal you can check if modal.portal == null.

[CompuIves]

Ah, that works, thanks! Added test.

[diasbruno]

yeah, that is correct.

[coveralls]

Coverage remained the same at 84.956% when pulling 9f3fd85 on CompuIves:master into 8f3898a on reactjs:master.

[diasbruno]

You can squash the commits and append [chore] at the begging of the commit message and it is good to merge.

[CompuIves]

Done!

[coveralls]

Coverage remained the same at 84.956% when pulling 1639de8 on CompuIves:master into 8f3898a on reactjs:master.