Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of CommonJS module #299

Merged

Conversation

hiroppy
Copy link
Contributor

@hiroppy hiroppy commented Jan 2, 2017

Changes proposed:

  • Make use of es6 module

Upgrade Path (for changed or removed APIs):

Acceptance Checklist:

  • All commits have been squashed to one.
  • The commit message follows the guidelines in CONTRIBUTING.md.
  • Documentation (README.md) and examples have been updated as needed.
  • If this is a code change, a spec testing the functionality has been added.
  • If the commit message has [changed] or [removed], there is an upgrade path above.

module.exports = require('./components/Modal');

import Modal from './components/Modal.js';
export default Modal;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better(?) to use export-default-from, but this is stage-1.
What do you think?

export-default-from

export default from './components/Modal';

@hiroppy hiroppy force-pushed the feature/get-rid-of-commonjs-modules branch from a0c423c to f925347 Compare January 2, 2017 11:22
@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 77.256% when pulling f925347 on abouthiroppy:feature/get-rid-of-commonjs-modules into b261459 on reactjs:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 77.256% when pulling f925347 on abouthiroppy:feature/get-rid-of-commonjs-modules into b261459 on reactjs:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 77.256% when pulling f925347 on abouthiroppy:feature/get-rid-of-commonjs-modules into b261459 on reactjs:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 77.256% when pulling f925347 on abouthiroppy:feature/get-rid-of-commonjs-modules into b261459 on reactjs:master.

@claydiffrient claydiffrient merged commit a776118 into reactjs:master Jan 3, 2017
@hiroppy hiroppy deleted the feature/get-rid-of-commonjs-modules branch January 3, 2017 05:45
@diasbruno diasbruno mentioned this pull request Jun 14, 2017
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants