Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds onAfterClose #346

Closed
wants to merge 2 commits into from
Closed

Adds onAfterClose #346

wants to merge 2 commits into from

Conversation

catamphetamine
Copy link

Fixes #214

Changes proposed:
Adds onAfterClose handler

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 80.836% when pulling 15c6490 on halt-hammerzeit:master into a8b7aa0 on reactjs:master.

diasbruno
diasbruno requested changes Mar 3, 2017
View reviewed changes
Copy link
Collaborator

@diasbruno diasbruno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test case. :)

@catamphetamine
Copy link
Author

Actually, I found another way: simply componentWillUnmount() in the modal contents component

@jcrben jcrben mentioned this pull request Nov 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diasbruno diasbruno diasbruno requested changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@catamphetamine @coveralls @diasbruno