Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fixed] Eliminate unnecessary renders when modal is closed #431

Merged
merged 1 commit into from
Jun 20, 2017

Conversation

fuller
Copy link
Contributor

@fuller fuller commented Jun 19, 2017

Fixes #[issue number].

Changes proposed:

I wasn't exactly sure if we wanted another test as all current tests are passing and this one (https://github.com/reactjs/react-modal/blob/master/specs/Modal.spec.js#L233) covers the scenario of multiple modals rendering.

Upgrade Path (for changed or removed APIs):

Acceptance Checklist:

  • All commits have been squashed to one.
  • The commit message follows the guidelines in CONTRIBUTING.md.
  • Documentation (README.md) and examples have been updated as needed.
  • If this is a code change, a spec testing the functionality has been added.
  • If the commit message has [changed] or [removed], there is an upgrade path above.

@fuller fuller changed the title [fixed] Unnecessary renders when modal is closed [fixed] Eliminate unnecessary renders when modal is closed Jun 19, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 71.429% when pulling 430aa83 on ajfuller:fix/unnecessary-renders into 6c780ae on reactjs:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 71.429% when pulling 430aa83 on ajfuller:fix/unnecessary-renders into 6c780ae on reactjs:master.

@diasbruno diasbruno merged commit 7da6ec8 into reactjs:master Jun 20, 2017
@diasbruno
Copy link
Collaborator

Released v2.0.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants