[fixed] Eliminate unnecessary renders when modal is closed #431
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #[issue number].
Changes proposed:
renderPortal
again unnecessarily. This was my original intention with [fixed] Multiple modals on page causing contradictory class updates #328, but is greatly simplified with v2 code.I wasn't exactly sure if we wanted another test as all current tests are passing and this one (https://github.com/reactjs/react-modal/blob/master/specs/Modal.spec.js#L233) covers the scenario of multiple modals rendering.
Upgrade Path (for changed or removed APIs):
Acceptance Checklist:
CONTRIBUTING.md
.