Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[added] allow users to pass aria-* attributes. #442

Merged

Conversation

diasbruno
Copy link
Collaborator

@diasbruno diasbruno commented Jun 27, 2017

This patch allows users to pass custom aria attributes
to be added to the modal content.

It accepts an object where the keys are the names of the attributes
without the prefix aria-.

aria attribute is optional.

Usage

<Modal 
   ...
   aria={{
      describedby: "Aid",
      labelledby: "Bid"
   }} />

Changes proposed:

Upgrade Path (for changed or removed APIs):

  • None.

Acceptance Checklist:

  • All commits have been squashed to one.
  • The commit message follows the guidelines in CONTRIBUTING.md.
  • Documentation (README.md) and examples have been updated as needed.
  • If this is a code change, a spec testing the functionality has been added.
  • If the commit message has [changed] or [removed], there is an upgrade path above.

@diasbruno diasbruno force-pushed the feature/allow-custom-aria-attributes branch 2 times, most recently from 85811f3 to dc4dc95 Compare June 27, 2017 02:51
@diasbruno diasbruno changed the title [added] allow users to pass aria-* attribute. [added] allow users to pass aria-* attributes. Jun 27, 2017
@diasbruno diasbruno force-pushed the feature/allow-custom-aria-attributes branch 5 times, most recently from d5931b1 to 2bec9e3 Compare June 27, 2017 03:12
@coveralls
Copy link

coveralls commented Jun 27, 2017

Coverage Status

Coverage increased (+0.2%) to 85.714% when pulling 2bec9e3 on diasbruno:feature/allow-custom-aria-attributes into e5090de on reactjs:master.

@coveralls
Copy link

coveralls commented Jun 27, 2017

Coverage Status

Coverage increased (+0.2%) to 85.714% when pulling 2bec9e3 on diasbruno:feature/allow-custom-aria-attributes into e5090de on reactjs:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 85.714% when pulling 2bec9e3 on diasbruno:feature/allow-custom-aria-attributes into e5090de on reactjs:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 85.714% when pulling 2bec9e3 on diasbruno:feature/allow-custom-aria-attributes into e5090de on reactjs:master.

@diasbruno diasbruno force-pushed the feature/allow-custom-aria-attributes branch from 2bec9e3 to 45990b0 Compare June 27, 2017 13:37
This patch allows users to pass custom aria attributes
to be added to the modal content.

It accepts an object where the keys are the name of the attributes
without the prefix aria-*.
@diasbruno diasbruno force-pushed the feature/allow-custom-aria-attributes branch from 45990b0 to 222e708 Compare June 27, 2017 13:38
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 85.714% when pulling 222e708 on diasbruno:feature/allow-custom-aria-attributes into e5090de on reactjs:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 85.714% when pulling 222e708 on diasbruno:feature/allow-custom-aria-attributes into e5090de on reactjs:master.

@coveralls
Copy link

coveralls commented Jun 27, 2017

Coverage Status

Coverage increased (+0.2%) to 85.714% when pulling 222e708 on diasbruno:feature/allow-custom-aria-attributes into e5090de on reactjs:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants