-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[added] allow users to pass aria-* attributes. #442
Merged
diasbruno
merged 1 commit into
reactjs:master
from
diasbruno:feature/allow-custom-aria-attributes
Jun 28, 2017
Merged
[added] allow users to pass aria-* attributes. #442
diasbruno
merged 1 commit into
reactjs:master
from
diasbruno:feature/allow-custom-aria-attributes
Jun 28, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
85811f3
to
dc4dc95
Compare
d5931b1
to
2bec9e3
Compare
1 similar comment
2bec9e3
to
45990b0
Compare
This patch allows users to pass custom aria attributes to be added to the modal content. It accepts an object where the keys are the name of the attributes without the prefix aria-*.
45990b0
to
222e708
Compare
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows users to pass custom aria attributes
to be added to the modal content.
It accepts an object where the keys are the names of the attributes
without the prefix
aria-
.aria
attribute is optional.Usage
Changes proposed:
Upgrade Path (for changed or removed APIs):
Acceptance Checklist:
CONTRIBUTING.md
.