Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fixed] Modal.removePortal not called when using closetimeoutMS #447

Merged
merged 1 commit into from
Jun 29, 2017
Merged

[fixed] Modal.removePortal not called when using closetimeoutMS #447

merged 1 commit into from
Jun 29, 2017

Conversation

seanich
Copy link
Contributor

@seanich seanich commented Jun 29, 2017

Acceptance Checklist:

  • All commits have been squashed to one.
  • The commit message follows the guidelines in CONTRIBUTING.md.
  • Documentation (README.md) and examples have been updated as needed.
  • If this is a code change, a spec testing the functionality has been added.
  • If the commit message has [changed] or [removed], there is an upgrade path above.

@seanich seanich changed the title [fixed] Modal.removePortal was not being called when using closetimeoutMS [fixed] Modal.removePortal not called when using closetimeoutMS Jun 29, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+1.08%) to 86.792% when pulling 6593bea on seanich:fix-remove-after-timeout into f386aa4 on reactjs:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+1.08%) to 86.792% when pulling 6593bea on seanich:fix-remove-after-timeout into f386aa4 on reactjs:master.

diasbruno
diasbruno requested changes Jun 29, 2017
View reviewed changes
src/components/Modal.js Outdated
@@ -140,7 +140,7 @@ export default class Modal extends Component {
this.portal.closeWithTimeout();
}

setTimeout(() => this.removePortal, closesAt - now);
setTimeout(() => this.removePortal(), closesAt - now);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is correct. You can remove the arrow function and it should work.

setTimeout(this.removePortal, closesAt - now);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I've updated my commit to remove the arrow function.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.007%) to 86.721% when pulling f7897a4 on seanich:fix-remove-after-timeout into f386aa4 on reactjs:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+1.007%) to 86.721% when pulling f7897a4 on seanich:fix-remove-after-timeout into f386aa4 on reactjs:master.

@diasbruno
Copy link
Collaborator

Thank you, @seanich!

@diasbruno diasbruno merged commit f47e79d into reactjs:master Jun 29, 2017
@diasbruno
Copy link
Collaborator

Release v2.2.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diasbruno diasbruno diasbruno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@seanich @coveralls @diasbruno