Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Mention shouldCloseOnOverlayClick dependency #463

Closed
wants to merge 1 commit into from
Closed

[chore] Mention shouldCloseOnOverlayClick dependency #463

wants to merge 1 commit into from

Conversation

whitecrownclown
Copy link
Contributor

@whitecrownclown whitecrownclown commented Jul 25, 2017

Mention shouldCloseOnOverlayClick dependency on onRequestClose in order to function properly.

Changes proposed:

  • add mention that shouldCloseOnOverlayClick depends on having the onRequestClose prop in order to function properly when it's set to true

Acceptance Checklist:

  • All commits have been squashed to one.
  • The commit message follows the guidelines in CONTRIBUTING.md.
  • Documentation (README.md) and examples have been updated as needed.
  • If this is a code change, a spec testing the functionality has been added.
  • If the commit message has [changed] or [removed], there is an upgrade path above.

Mention shouldCloseOnOverlayClick dependency on onRequestClose in order to function properly.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.173% when pulling 43a339b on whitecrownclown:patch-1 into a2d5c4e on reactjs:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.173% when pulling 43a339b on whitecrownclown:patch-1 into a2d5c4e on reactjs:master.

@diasbruno
Copy link
Collaborator

@whitecrownclown Thank you!

@whitecrownclown whitecrownclown deleted the patch-1 branch July 25, 2017 22:47
@whitecrownclown whitecrownclown restored the patch-1 branch July 25, 2017 22:47
@coveralls
Copy link

coveralls commented Jul 25, 2017

Coverage Status

Coverage remained the same at 87.173% when pulling 43a339b on whitecrownclown:patch-1 into a2d5c4e on reactjs:master.

@diasbruno
Copy link
Collaborator

Related #462.

@diasbruno
Copy link
Collaborator

@whitecrownclown can you add to your commit message [chore]?

@diasbruno diasbruno changed the title [added] Mention shouldCloseOnOverlayClick dependency [chore] Mention shouldCloseOnOverlayClick dependency Jul 26, 2017
@whitecrownclown
Copy link
Contributor Author

@diasbruno I believe you already did, i'm not really used to contributing to github yet, i appreciate any help in getting used to it.

@diasbruno
Copy link
Collaborator

diasbruno commented Jul 26, 2017

@whitecrownclown that was the title of the issue.

On your last git commit, try to find on your tool where you can amend or edit to the commit message (or on your terminal you can git commit --amend -m "[chore] {the message}".

@diasbruno
Copy link
Collaborator

@whitecrownclown Thank you so much. Your commit is 92c23b5.

@diasbruno diasbruno closed this Jul 27, 2017
@whitecrownclown whitecrownclown deleted the patch-1 branch July 28, 2017 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants