-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Mention shouldCloseOnOverlayClick dependency #463
Conversation
Mention shouldCloseOnOverlayClick dependency on onRequestClose in order to function properly.
1 similar comment
@whitecrownclown Thank you! |
Related #462. |
@whitecrownclown can you add to your commit message |
@diasbruno I believe you already did, i'm not really used to contributing to github yet, i appreciate any help in getting used to it. |
@whitecrownclown that was the title of the issue. On your last git commit, try to find on your tool where you can |
@whitecrownclown Thank you so much. Your commit is 92c23b5. |
Mention shouldCloseOnOverlayClick dependency on onRequestClose in order to function properly.
Changes proposed:
shouldCloseOnOverlayClick
depends on having theonRequestClose
prop in order to function properly when it's set totrue
Acceptance Checklist:
CONTRIBUTING.md
.