Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fixed] Render testId property #695

Merged
merged 1 commit into from
Oct 27, 2018

Conversation

adammahmood
Copy link
Contributor

@adammahmood adammahmood commented Oct 5, 2018

Fixes #694

Changes proposed:

Upgrade Path (for changed or removed APIs):

N/A

Acceptance Checklist:

  • The commit message follows the guidelines in CONTRIBUTING.md.
  • Documentation (README.md) and examples have been updated as needed.
  • If this is a code change, a spec testing the functionality has been added.
  • If the commit message has [changed] or [removed], there is an upgrade path above.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.697% when pulling aa704e7 on adammahmood:fix-testid-attribute into 1b561fc on reactjs:master.

@diasbruno
Copy link
Collaborator

Hi @adammahmood. I think we can close this one in favour of #695. What do you think?

@adammahmood
Copy link
Contributor Author

adammahmood commented Oct 12, 2018

@diasbruno Did you intend to reference #695? (as that's this PR)

@diasbruno
Copy link
Collaborator

@adammahmood Sorry, mentioned the wrong PR. :) PR #696.

@adammahmood
Copy link
Contributor Author

@diasbruno No worries. I agree. We should favour #696 and remove references of testId.

@diasbruno
Copy link
Collaborator

diasbruno commented Oct 12, 2018

I think we can merge this PR for v3 and merge #696 for v4. This way we break compatibility on a major release.

@diasbruno diasbruno merged commit 6a6bcf7 into reactjs:master Oct 27, 2018
@diasbruno
Copy link
Collaborator

Thanks, @adammahmood. Soon I'll make a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants