Disable focus trap & disable tab trap #876
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diasbruno
reviewed
May 28, 2021
| if (instances.length > 0) { | ||
| const trapFocus = instances.find(({ props }) => !props.disableFocusTrap); | ||
|
|
||
| if (trapFocus && instances.length > 0) { |
There was a problem hiding this comment.
What happens if we open one modal with focus trap disabled and one that's enabled?
There was a problem hiding this comment.
Then a focus trap will exist. I thought that is the best way to do it as it gives existing functionality priority over the added functionality. I could add something in the readme to let the user know?
There was a problem hiding this comment.
I added a comment in the readme about this
diasbruno
reviewed
May 28, 2021
Co-authored-by: Bruno Dias <dias.h.bruno@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #[issue number].
Changes proposed:
Acceptance Checklist:
CONTRIBUTING.md.