feat: support other js package managers #1306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
justin808
reviewed
Oct 19, 2023
|
@G-Rath let me know when ready to merge and release. |
|
@ahangarha @G-Rath can I merge once CI passes? |
3 tasks
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
3 tasks
This comment was marked as resolved.
This comment was marked as resolved.
|
@justin808 this should be good to go! |
|
@G-Rath Let me know if you need a release ASAP. |
3 tasks
G-Rath
added a commit
to ackama/rails-template
that referenced
this pull request
Jan 26, 2024
…#528) [`react-rails` now supports other package managers](reactjs/react-rails#1306) using `package_json`, meaning it now defaults to `npm` if a package manager is not explicitly set in `package.json`, causing a stray `package-lock.json` to be created. I've specified an exact version because currently `corepack` requires that ([ranges are not yet supported](nodejs/corepack#95)) but we're not actually expecting anyone to be using `corepack` and we're definitely not using it in production (not explicitly at least...) so in theory this shouldn't cause problems and it means `package.json` conforms to the JSON schema - it'll also help to flush out any potential problems early before(/if) `corepack` becomes more mainstream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See shakacode/shakapacker#349 and shakacode/shakapacker#195
Other Information
This is also passing CI in our
rails-template.Pull Request checklist