Use location descriptor in onEnter redirect #2855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://github.com/rackt/react-router/blob/master/upgrade-guides/v2.0.0.md#link-to-and-isactive-take-location-descriptors needs to be updated to include this, but I didn't want to break the tiny.cc link. I guess we should probably add a codemod here. |
|
I can update the tiny.cc links if the URL structure changes. That's why I chose them over bit.ly 😄 |
|
@timdorr Do you want me to update that section, then, and you can update tiny.cc as you merge? |
|
Yeah, go for it. I'll take care of the links. |
|
@timdorr Updated the PR. Can you update the links and merge when ready? |
|
Sorry, I didn't have a chance to look over this last night as it's more substantial than just some docs updates. LGTM though. |
timdorr
added a commit
that referenced
this pull request
Jan 7, 2016
Use location descriptor in onEnter redirect
|
Link updated: http://tiny.cc/router-isActivedeprecated |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2828