Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use location descriptor in onEnter redirect #2855

Merged
merged 1 commit into from
Jan 7, 2016
Merged

Use location descriptor in onEnter redirect #2855

merged 1 commit into from
Jan 7, 2016

Conversation

taion
Copy link
Contributor

@taion taion commented Jan 6, 2016

Fixes #2828

@taion
Copy link
Contributor Author

taion commented Jan 6, 2016

@timdorr

https://github.com/rackt/react-router/blob/master/upgrade-guides/v2.0.0.md#link-to-and-isactive-take-location-descriptors needs to be updated to include this, but I didn't want to break the tiny.cc link.

I guess we should probably add a codemod here.

@timdorr
Copy link
Member

timdorr commented Jan 6, 2016

I can update the tiny.cc links if the URL structure changes. That's why I chose them over bit.ly 😄

@taion
Copy link
Contributor Author

taion commented Jan 6, 2016

@timdorr Do you want me to update that section, then, and you can update tiny.cc as you merge?

@timdorr
Copy link
Member

timdorr commented Jan 6, 2016

Yeah, go for it. I'll take care of the links.

@taion
Copy link
Contributor Author

taion commented Jan 6, 2016

@timdorr Updated the PR. Can you update the links and merge when ready?

@timdorr
Copy link
Member

timdorr commented Jan 7, 2016

Sorry, I didn't have a chance to look over this last night as it's more substantial than just some docs updates.

LGTM though.

timdorr added a commit that referenced this pull request Jan 7, 2016
Use location descriptor in onEnter redirect
@timdorr timdorr merged commit 282827e into remix-run:master Jan 7, 2016
@timdorr
Copy link
Member

timdorr commented Jan 7, 2016

Link updated: http://tiny.cc/router-isActivedeprecated

@taion taion deleted the onEnter-location-descriptor branch January 8, 2016 07:09
@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants