Add note about animation timing in the docs #313
Conversation
|
Looks good. I wonder if we should re word this whole section to all about how the state transitions proceed regardless of the actual animation and it's up to the implementor to match them correctly. That's not the ”right" way to say what I'm thinking but you know...the idea is Transition provides a skeleton to hang animation on,which means it could be done wrong |
|
I'm not sure I understand, could you elaborate? |
|
Sorry, i got lost thinking a bit more wider focus about how we describe Transition. Part of the problem that folks run into like the timeout and reflow issues generally stem from folks thinking the component will implement proper css transitions for them, when really the component is a more of a wireframe that you build implementations on top off. We should probably do a better job of explaining that more broadly. as a Pr this is GTG and right on the moment 👍 |
|
You're right, I'll add that as well. 👍 |
It creates unnecessary gaps.
|
I added the short description of the library on the home page where I wrote how react-transition-group does not animate styles, just provides better means for defining your own transitions. Feel free to merge if you're happy with this. |
www/src/pages/index.js
Outdated
| it does not animate styles by itself. Instead it exposes transition | ||
| stages, manages classes and group elements and manipulates the DOM | ||
| in useful ways, making the implementation of visual transitions up | ||
| in useful ways, making the implementation of actual visual |
|
🎉 This PR is included in version 2.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Will hopefully help clarify issues like #284.